[
https://issues.apache.org/jira/browse/PHOENIX-5976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17159658#comment-17159658
]
Hadoop QA commented on PHOENIX-5976:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13007821/PHOENIX-5976.4.x.patch
against 4.x branch at commit 07f1fea40804a9c65e04e336afbeecab534372e0.
ATTACHMENT ID: 13007821
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 5 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ stmt.execute("CREATE TABLE IF NOT EXISTS " + table + " (ID
CHAR(10) NOT NULL,KEY_PREFIX CHAR(3) NOT NULL," +
+ "CREATE VIEW IF NOT EXISTS " + view + " (PK1 DATE NOT
NULL,PK2 CHAR(15) NOT NULL," +
+ "NON_PK1 CHAR(15),NON_PK2 CHAR(15) CONSTRAINT
PKVIEW PRIMARY KEY (PK1,PK2)) " +
+ stmt.execute("CREATE INDEX " + index + " ON " + view + " (PK2,
PK1) INCLUDE (NON_PK1, NON_PK2)");
+ stmt.execute("CREATE TABLE IF NOT EXISTS " + table + " (ID
CHAR(10) NOT NULL,KEY_PREFIX CHAR(3) NOT NULL," +
+ "CREATE VIEW IF NOT EXISTS " + view + " (PK1 DATE
NOT NULL,PK2 CHAR(15) NOT NULL," +
+ "NON_PK1 CHAR(15),NON_PK2 CHAR(15) CONSTRAINT
PKVIEW PRIMARY KEY (PK1,PK2)) " +
+ stmt.execute("CREATE INDEX " + index + " ON " + view + " (PK2,
PK1) INCLUDE (NON_PK1, NON_PK2)");
+ stmt.execute("CREATE TABLE IF NOT EXISTS " + table + " (ID
CHAR(10) NOT NULL,KEY_PREFIX CHAR(3) NOT NULL, NON_PK1 CHAR(15),NON_PK2
CHAR(15), " +
+ stmt.execute("CREATE INDEX " + index + " ON " + table +"
(KEY_PREFIX, ID) INCLUDE (NON_PK1, NON_PK2)");
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4051//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4051//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4051//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4051//console
This message is automatically generated.
> Cannot drop a column when the index view is involved
> -----------------------------------------------------
>
> Key: PHOENIX-5976
> URL: https://issues.apache.org/jira/browse/PHOENIX-5976
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 4.16.0
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Blocker
> Fix For: 4.16.0
>
> Attachments: PHOENIX-5976.4.x.patch
>
>
> This is how to reproduce it on the 4.x branch:
> {code:java}
> // create table
> stmt.execute("CREATE TABLE IF NOT EXISTS DUMMY (ID CHAR(10) NOT
> NULL,KEY_PREFIX CHAR(3) NOT NULL," +
> " CONSTRAINT PK PRIMARY KEY (ID,KEY_PREFIX))");
> // create view
> stmt.execute(
> "CREATE VIEW IF NOT EXISTS DUMMY_VIEW (PK1 DATE NOT NULL,PK2
> CHAR(15) NOT NULL," +
> "NON_PK1 CHAR(15),NON_PK2 CHAR(15) CONSTRAINT PKVIEW PRIMARY
> KEY (PK1,PK2)) " +
> "AS SELECT * FROM DUMMY WHERE KEY_PREFIX = '123'");
> // create index
> stmt.execute("CREATE INDEX DUMMY_INDEX ON DUMMY_VIEW (PK2, PK1) INCLUDE
> (NON_PK1, NON_PK2)");
> // drop column
> stmt.execute("ALTER VIEW DUMMY_VIEW DROP COLUMN IF EXISTS NON_PK1");
> {code}
> {code:java}
> org.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703): ERROR 504
> (42703): Undefined column. columnName=0:NON_PK2
> DUMMY_VIEWorg.apache.hadoop.hbase.DoNotRetryIOException: ERROR 504 (42703):
> ERROR 504 (42703): Undefined column. columnName=0:NON_PK2 DUMMY_VIEW at
> org.apache.phoenix.util.ServerUtil.createIOException(ServerUtil.java:114) at
> org.apache.phoenix.util.ServerUtil.throwIOException(ServerUtil.java:88) at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2823)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.dropColumn(MetaDataEndpointImpl.java:3026)
> at
> org.apache.phoenix.coprocessor.generated.MetaDataProtos$MetaDataService.callMethod(MetaDataProtos.java:17253)
> at
> org.apache.hadoop.hbase.regionserver.HRegion.execService(HRegion.java:8523)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execServiceOnRegion(RSRpcServices.java:2282)
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.execService(RSRpcServices.java:2264)
> at
> org.apache.hadoop.hbase.protobuf.generated.ClientProtos$ClientService$2.callBlockingMethod(ClientProtos.java:36808)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2399) at
> org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:124) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:311) at
> org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:291)Caused
> by: org.apache.phoenix.schema.ColumnNotFoundException: ERROR 504 (42703):
> Undefined column. columnName=0:NON_PK2 at
> org.apache.phoenix.schema.PColumnFamilyImpl.getPColumnForColumnNameBytes(PColumnFamilyImpl.java:86)
> at org.apache.phoenix.util.MetaDataUtil.getColumn(MetaDataUtil.java:982) at
> org.apache.phoenix.coprocessor.DropColumnMutator.validateAndAddMetadata(DropColumnMutator.java:184)
> at
> org.apache.phoenix.coprocessor.MetaDataEndpointImpl.mutateColumn(MetaDataEndpointImpl.java:2719)
> ... 10 more
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)