[
https://issues.apache.org/jira/browse/PHOENIX-6017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17160156#comment-17160156
]
Chinmay Kulkarni commented on PHOENIX-6017:
-------------------------------------------
[~stoty] Thanks! Somehow even after the change, the above build complained
about the dpr file's license, but when I ran
{code:bash}
mvn clean package -DskipTests -DPhoenixPatchProcess
{code}
on my local machine, it doesn't create the dpr after my changes are applied.
Comparing with a previous build
[4049|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4049//consoleFull]
however, I no longer see the log line:
{code:java}
18:22:36 [INFO] Dependency-reduced POM written at:
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-server/dependency-reduced-pom.xml
{code}
so not sure how it was still created.
For phoenix-client, the dpr is written to the target directory, so I think that
should be fine:
{code:java}
17:09:34 [INFO] Dependency-reduced POM written at:
/home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-client/target/pom.xml
{code}
In fact, for consistency I will do the same for the dpr in phoenix-server by
changing its location in v2. Will put that up shortly
> Hadoop QA Precommit build keeps failing with release audit warning for
> phoenix-server/dependency-reduced-pom.xml
> ----------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6017
> URL: https://issues.apache.org/jira/browse/PHOENIX-6017
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Labels: beginner, newbie, phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6017-4.x-v1.patch, PHOENIX-6017-4.x-v2.patch
>
>
> I believe this is introduced by some changes related to the maven-shaded
> plugin. We create a dependency-reduced-pom.xml which is considered during the
> license header check, thus always causing preCommit to fail on this step. We
> should prevent its creation perhaps via something like
> [this|https://stackoverflow.com/questions/11314182/maven-shade-plugin-adding-dependency-reduced-pom-xml-to-base-directory].
> Example of a failing build's error:
> {code:java}
> 1 Unknown Licenses
> *****************************************************
> Files with unapproved licenses:
>
> /home/jenkins/jenkins-slave/workspace/PreCommit-PHOENIX-Build/phoenix-server/dependency-reduced-pom.xml
> *****************************************************
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
