[ https://issues.apache.org/jira/browse/PHOENIX-5986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17163164#comment-17163164 ]
Hadoop QA commented on PHOENIX-5986: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/13008201/PHOENIX-5986.4.x.004.patch against 4.x branch at commit 218a71c07259a6ac4660335bf3636325e1ee138d. ATTACHMENT ID: 13008201 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 0 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + IndexRebuildTaskIT.waitForTaskState(conn, PTable.TaskType.DROP_CHILD_VIEWS, null, PTable.TaskStatus.COMPLETED); + stmt += " AND " + PhoenixDatabaseMetaData.TABLE_NAME + "='" + expectedTableName + "'"; + LOGGER.info("Adding task " + taskType + "," +tableName + "," + taskStatus + "," + startTs, ","+endTs); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DynamicColumnIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4071//testReport/ Code Coverage results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4071//artifact/phoenix-core/target/site/jacoco/index.html Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/4071//console This message is automatically generated. > DropTableWithViewsIT.testDropTableWithChildViews is flapping again > ------------------------------------------------------------------ > > Key: PHOENIX-5986 > URL: https://issues.apache.org/jira/browse/PHOENIX-5986 > Project: Phoenix > Issue Type: Bug > Affects Versions: 4.15.0 > Reporter: Chinmay Kulkarni > Assignee: Gokcen Iskender > Priority: Major > Labels: phoenix-hardening, quality-improvement > Fix For: 4.16.0 > > Attachments: PHOENIX-5986.4.x.001.patch, PHOENIX-5986.4.x.002.patch, > PHOENIX-5986.4.x.003.patch, PHOENIX-5986.4.x.004.patch, > PHOENIX-5986.master.001.patch, PHOENIX-5986.master.002.patch, > PHOENIX-5986.master.003.patch, PHOENIX-5986.master.004.patch, > PHOENIX-5986.master.005.patch, build-4022-full-console-log.txt, > build-4023-full-console-log.txt > > Time Spent: 1h 10m > Remaining Estimate: 0h > > DropTableWithViewsIT.testDropTableWithChildViews is flapping again. I see > [PHOENIX-5074|https://issues.apache.org/jira/browse/PHOENIX-5074] fixed this > test so that the task is run immediately, but somehow this test is still > intermittently failing. > This has caused recent preCommit failures for PHOENIX-5981 (build > [4010|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4010//testReport/]) > and > PHOENIX-5984 (build > [4011|https://builds.apache.org/job/PreCommit-PHOENIX-Build/4011//testReport/]). > When I run this test locally, it passes sometimes and fails sometimes. This > is the relevant stack trace: > {code:java} > java.lang.AssertionError > at org.junit.Assert.fail(Assert.java:87) > at org.junit.Assert.assertTrue(Assert.java:42) > at org.junit.Assert.assertFalse(Assert.java:65) > at org.junit.Assert.assertFalse(Assert.java:75) > at > org.apache.phoenix.end2end.DropTableWithViewsIT.testDropTableWithChildViews(DropTableWithViewsIT.java:158) > {code} > Failure is observed in [this > assertion|https://github.com/apache/phoenix/blob/f5ebf2aaa337d0b4b935f10917cee3d99d621c98/phoenix-core/src/it/java/org/apache/phoenix/end2end/DropTableWithViewsIT.java#L158]. > I also see that the test sometimes fails because it expects task status to > be COMPLETED, but sees status to be STARTED instead. -- This message was sent by Atlassian Jira (v8.3.4#803005)