[
https://issues.apache.org/jira/browse/PHOENIX-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164934#comment-17164934
]
Hadoop QA commented on PHOENIX-5958:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13008408/PHOENIX-5958-4.x-v2.patch
against 4.x branch at commit ce83d74050a8cc1637068f3fb8980e14f9bde611.
ATTACHMENT ID: 13008408
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ * TODO: Update all comments since we don't go here if diverged view
created by pre-4.15 client. Also try to simplify
+ if (!isDiverged && ancestorColumn.getTimestamp() >
existingColumn.getTimestamp()) {
+ } else {// TODO: Check this case. and especially inner if
condition since ancestorColumn.isExcluded() can never be true here.
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpgradeIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4078//console
This message is automatically generated.
> Diverged view created via an older client still sees dropped column data
> ------------------------------------------------------------------------
>
> Key: PHOENIX-5958
> URL: https://issues.apache.org/jira/browse/PHOENIX-5958
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-5958-4.x-v2.patch
>
>
> By "diverged view" I mean creating a view and then dropping one of the
> inherited columns from the view. Steps to reproduce:
> Start a 4.x server and connect with a pre-4.15 (I tried a 4.14.3) client
> {code:sql}
> CREATE TABLE IF NOT EXISTS S.T (A INTEGER PRIMARY KEY, B INTEGER);
> CREATE VIEW IF NOT EXISTS S.V (new_col INTEGER) AS SELECT * FROM S.T;
> UPSERT INTO S.T VALUES(1,2);
> ALTER VIEW S.V DROP COLUMN B;
> SELECT * FROM S.T;
> +----+------+
> | A | B |
> +----+------+
> | 1 | 2 |
> +----+------+
> SELECT * FROM S.V; gives:
> +----+------+----------+
> | B | A | NEW_COL |
> +----+------+----------+
> | 2 | 1 | null |
> +----+------+----------+
> {code}
> Though the column 'B' has been dropped from the view. This is a problem for
> both when phoenix.allow.system.catalog.rollback=true or false. This exact bug
> does not happen for a 4.x client, though PHOENIX-6030 and PHOENIX-6032
> highlight other issues related to this code path for 4.x clients.
> The problem is mostly due to changes introduced by
> [PHOENIX-4893|https://issues.apache.org/jira/browse/PHOENIX-4893]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
