[
https://issues.apache.org/jira/browse/PHOENIX-6045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17166097#comment-17166097
]
Hadoop QA commented on PHOENIX-6045:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13008521/PHOENIX-6045.4.x.001.patch
against 4.x branch at commit ce83d74050a8cc1637068f3fb8980e14f9bde611.
ATTACHMENT ID: 13008521
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ " (PKEY1 CHAR(15) NOT NULL, PKEY2 CHAR(15) NOT NULL, VAL1
CHAR(15), VAL2 CHAR(15)," +
+ String indexDdl1 = "CREATE INDEX IF NOT EXISTS " + indexName1 + " ON "
+ tableName + " (VAL1)";
+ String indexDdl2 = "CREATE INDEX IF NOT EXISTS " + indexName2 + " ON "
+ tableName + " (VAL2)";
+ conn.createStatement().execute("upsert into " + tableName +"
values ('PKEY1', 'PKEY2', '000000000000000', 'VAL2')");
+ // This is a projected table and may not include all the
indexed columns and so we need to get
+
SchemaUtil.getTableName(dataTable.getSchemaName().getString(),
dataTable.getTableName().getString()));
+ // Project all non PK indexed columns so that we can do the proper
index maintenance on the indexes for which
+ // mutations are generated on the client side. Indexed columns are
needed to identify index rows to be deleted
+ PColumn column = hasNoColumnFamilies ?
table.getColumnForColumnName(columnName) :
table.getColumnFamily(familyName).getPColumnForColumnName(columnName);
+ aliasedNodes.add(FACTORY.aliasedNode(null,
FACTORY.column(hasNoColumnFamilies ? null : TableName.create(null, familyName),
'"' + columnName + '"', null)));
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DeleteIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4081//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4081//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4081//console
This message is automatically generated.
> Delete that should qualify for index path does not use index when multiple
> indexes are available.
> -------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6045
> URL: https://issues.apache.org/jira/browse/PHOENIX-6045
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0, 4.14.3
> Reporter: Daniel Wong
> Assignee: Kadir OZDEMIR
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: MultipleDeleteReproIT.java, PHOENIX-6045.4.x.001.patch
>
>
> Delete that should qualify for index path does not use index when multiple
> indexes are available. Test case to reproduce will be below.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
