swaroopak commented on a change in pull request #848:
URL: https://github.com/apache/phoenix/pull/848#discussion_r461722705
##########
File path:
phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaExtractionProcessor.java
##########
@@ -54,9 +55,6 @@ public String process() throws Exception {
if (ddl != null) {
return ddl;
}
- if(this.table.getColumnFamilies().size() > 1 ) {
Review comment:
This PR does not completely support the multiple column families,
especially if there are different properties for each column family as
mentioned by Goeffrey on the previous review. Let's modify this if clause to be
specific unless you want to include the change in this one and completely get
rid of "Not Supported Exception".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
