[
https://issues.apache.org/jira/browse/PHOENIX-6022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17167553#comment-17167553
]
Hadoop QA commented on PHOENIX-6022:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13008713/PHOENIX-6022-4.x.patch
against 4.x branch at commit bb936d1fee64dc36281c48591e672da671a5878c.
ATTACHMENT ID: 13008713
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ + " CONSTRAINT TEST_SCHEMA_PK PRIMARY KEY
(ORGANIZATION_ID, TEST_ID) \n" + ")",tableName);
+ String query = String.format("SELECT * FROM %s OFFSET
(ORGANIZATION_ID,TEST_ID) = ('1','1')",tableName);
+ //Note that phoenix does not suport a rowkey with a null inserted so there
is no single key version of this.
+ + " CONSTRAINT TEST_SCHEMA_PK PRIMARY KEY (ORGANIZATION_ID,
TEST_ID) \n" + ")",tableName);
+ String query = String.format("SELECT * FROM %s OFFSET
(ORGANIZATION_ID,TEST_ID) = ('1',null)",tableName);
+ try (Statement statement = conn.createStatement() ; ResultSet rs2 =
statement.executeQuery(query) ) {
+ String preparedQuery = String.format("SELECT * FROM %s OFFSET
(ORGANIZATION_ID,TEST_ID) = (?,?)",tableName);
+ rowKeyColumnExpressionList =
rowKeyColumnExpressionOutput.getRowKeyColumnExpressions();
+ //We do not generate a point lookup today in phoenix if the rowkey has
a trailing null, we generate a range scan.
+ //Since we use a range scan to guarantee we get only the null
value and the upper bound is unset this suffices
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4085//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4085//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4085//console
This message is automatically generated.
> RVC Offset does not handle trailing nulls properly
> --------------------------------------------------
>
> Key: PHOENIX-6022
> URL: https://issues.apache.org/jira/browse/PHOENIX-6022
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.15.0, 4.16.0
> Reporter: Daniel Wong
> Assignee: Daniel Wong
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6022-4.x.patch, PHOENIX-6022-master.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> While working on PHOENIX-5924 found that if there was a trailing null the
> Phoenix Optimizer during resolution of the miniwhere does not generate a
> point get due to how we write/handle trailing nulls in the rowkey. The
> sanity check that it is a point get therefore fails. This causes an
> exception to be returned to the user.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
