[
https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17170369#comment-17170369
]
Daniel Wong commented on PHOENIX-6010:
--------------------------------------
Thanks for pinging me on one of the downstream. Just pinging some other people
on FYI. I think this is fine for phoenix master. I think we need to add
another subtask for phoenix-connectors as well unless you are considering that
as part of the phoenix changes. I would prefer another guava version but I
haven't checked all the considerations between Java7 and newer versions. I
know currently at least for 4.x there are some reasons to stay on java7, i'm
debating if on master do we have those same issues? Last discussion of java
compatibility https://issues.apache.org/jira/browse/PHOENIX-5855
FYI [~gjacoby] [~ckulkarni]
> Create phoenix-thirdparty, and consume guava through it
> -------------------------------------------------------
>
> Key: PHOENIX-6010
> URL: https://issues.apache.org/jira/browse/PHOENIX-6010
> Project: Phoenix
> Issue Type: Improvement
> Components: core, omid, tephra
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
>
> We have long-standing and well-documented problems with Guava, just like the
> rest of the Hadoop components.
> Adopt the solution used by HBase:
> * create phoenix-thirdparty repo
> * create a pre-shaded phoenix-shaded-guava artifact in it
> * Use the pre-shaded Guava in every phoenix component
> The advantages are well-known, but to name a few:
> * Phoenix will work with Hadoop 3.1.3+
> * One less CVE in our direct dependencies
> * No more conflict with our consumer's Guava versions
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
