[
https://issues.apache.org/jira/browse/PHOENIX-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176531#comment-17176531
]
Hadoop QA commented on PHOENIX-6069:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13009489/PHOENIX-6069-4.x.patch
against 4.x branch at commit 8e34b2bf14e5b6c45c7212104768792390cf0d06.
ATTACHMENT ID: 13009489
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 4 release
audit warnings (more than the master's current 0 warnings).
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalIndexOptimizationIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.DropIndexedColsIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4092//testReport/
Code Coverage results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4092//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4092//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/4092//console
This message is automatically generated.
> We should check that the parent table key is in the region in the
> MetaDataEndpointImpl.dropTable code
> -----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6069
> URL: https://issues.apache.org/jira/browse/PHOENIX-6069
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6069-4.x.patch
>
>
> The check
> [here|https://github.com/apache/phoenix/blob/1d844950bb4ec8221873ecd2b094c20f427cd984/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L2231]
> should check the parentLockKey instead of the lockKey for the current table
> which we've already checked before this. Seems to be a copy-paste error.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
