[
https://issues.apache.org/jira/browse/PHOENIX-6096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182519#comment-17182519
]
Istvan Toth commented on PHOENIX-6096:
--------------------------------------
I don't think that there's a problem here, [~larsh] .
The compat modules are named after the earliest Hbase version that they work
with. I.e, the current 2.1.6 compat module wouldn't work with HBase 2.1.5 ,as
there was a breaking _LimitedPrivate_ API change in 2.1.6 (IIRC multi-merge).
I've decided to name the modules with the full HBase version, as it allows us
to support API changes on patch releases, i.e, if a (theoretical) 2.2.11 was
released that changed the API we use, we can just add a new new compat-2.1.11
module, and do not have remove support for HBase 2.1.6-2.1.10. The same way we
could add a third module for HBase 2.1.?-2.1.5 this way as well.
It is not really issue on master where it's probably OK to support only the
latest HBase patch releases, but when (if) we release a Phoenix patch release
(i.e. 4.16.1 or 5.1.1) after the above theoretical HBase 2.1.11 was released,
and we used only the major and minor versions for the compat modules, then we
either couldn't add support for 2.1.11, or would have to drop support for
2.1.10 and earlier.
This isn't exactly intuitive, but this gives us the most flexibility. I hope I
was able to explain the rationale behind the current versioning scheme.
The enforcer checks that the2.1.6 module used with HBase 2.1.6+ , so I think
that it is OK. It's hard to read because of the entity encoding, but it's
actually**
{code:java}
&& hbasePatch >=6)
{code}
Did you run into some problems with the profiles/enforcer rules ?
> HBase versions do not natch between the 2.1 profile and the enforcer
> --------------------------------------------------------------------
>
> Key: PHOENIX-6096
> URL: https://issues.apache.org/jira/browse/PHOENIX-6096
> Project: Phoenix
> Issue Type: Bug
> Reporter: Lars Hofhansl
> Priority: Major
>
> The enforcer checks for HBase version 2.1.6 and the 2.1 profile requests
> 2.1.9.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
