[
https://issues.apache.org/jira/browse/PHOENIX-6093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17186022#comment-17186022
]
Jacob Isaac commented on PHOENIX-6093:
--------------------------------------
[~ckulkarni] [~yanxinyi]
I think the comments to include the name may be outdated.
The PHERF framework uses a rules-based data generator. The rules engine is
centered around data types, in other words, the data model is expressed as a
collection of rules for specific types and has logic in the RulesApplier class
to search for rules based on type. Thus adding a name or other fields to
equals() might break that functionality.
But adding a hashcode based on the type field is the right thing to do. (Java
101)
> adding hashcode to phoenix pherf Column class
> ---------------------------------------------
>
> Key: PHOENIX-6093
> URL: https://issues.apache.org/jira/browse/PHOENIX-6093
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Minor
> Attachments: PHOENIX-6093.patch
>
>
> The pherf Column class overrides equals but not hashcode. Adding hashcode so
> that we can fully support serial upsert in numerical data types.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
