yanxinyi commented on a change in pull request #878:
URL: https://github.com/apache/phoenix/pull/878#discussion_r487289670
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Noop.java
##########
@@ -0,0 +1,29 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/OperationGroup.java
##########
@@ -0,0 +1,26 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
nit: please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
Review comment:
why we are setting this to a negative number? Should be at lease 1?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
+ }
+
+ public int getBatchSize() {
+ return batchSize;
+ }
+
+ public void setBatchSize(int batchSize) {
Review comment:
I didn't see anywhere calling this set method. Where is the place that
we are setting this batch size value?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Noop.java
##########
@@ -0,0 +1,29 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/OperationGroup.java
##########
@@ -0,0 +1,26 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
nit: please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
Review comment:
why we are setting this to a negative number? Should be at lease 1?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
+ }
+
+ public int getBatchSize() {
+ return batchSize;
+ }
+
+ public void setBatchSize(int batchSize) {
Review comment:
I didn't see anywhere calling this set method. Where is the place that
we are setting this batch size value?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Noop.java
##########
@@ -0,0 +1,29 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/OperationGroup.java
##########
@@ -0,0 +1,26 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
nit: please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
Review comment:
why we are setting this to a negative number? Should be at lease 1?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
+ }
+
+ public int getBatchSize() {
+ return batchSize;
+ }
+
+ public void setBatchSize(int batchSize) {
Review comment:
I didn't see anywhere calling this set method. Where is the place that
we are setting this batch size value?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/Noop.java
##########
@@ -0,0 +1,29 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/OperationGroup.java
##########
@@ -0,0 +1,26 @@
+package org.apache.phoenix.pherf.configuration;
Review comment:
nit: please add apache license
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
Review comment:
why we are setting this to a negative number? Should be at lease 1?
##########
File path:
phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java
##########
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.phoenix.pherf.configuration;
+
+import javax.xml.bind.annotation.XmlAttribute;
+import javax.xml.bind.annotation.XmlType;
+import java.util.List;
+
+@XmlType
+public class LoadProfile {
+
+ private int batchSize;
+ private int numOperations;
+ List<TenantGroup> tenantDistribution;
+ List<OperationGroup> opDistribution;
+
+ public LoadProfile() {
+ this.batchSize = Integer.MIN_VALUE;
+ }
+
+ public int getBatchSize() {
+ return batchSize;
+ }
+
+ public void setBatchSize(int batchSize) {
Review comment:
I didn't see anywhere calling this set method. Where is the place that
we are setting this batch size value?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
