[
https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17196558#comment-17196558
]
Hadoop QA commented on PHOENIX-5833:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13011573/PHOENIX-5833.4.x.patch
against 4.x branch at commit .
ATTACHMENT ID: 13011573
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 2 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ String ddl = String.format("create table %s(a varchar(10) not
null, b varchar(10) not null, c varchar(10) not null constraint pk primary
key(a, b, c))",tableName);
+ String conjunctionSelect = String.format("select A, B, C from %s
where (A, B, C) > ('abc', 'def', 'RRSQ_IMKKL') AND C like
'RRS\\\\_%%'",tableName);
+ try(Statement statement = conn.createStatement(); ResultSet rs =
statement.executeQuery(conjunctionSelect)) {
+ byte[] lowerBound =
phoenixStatement.getQueryPlan().getScans().get(0).get(0).getStartRow();
+
KeyRange.getKeyRange(PChar.INSTANCE.toBytes("A"), true,
PChar.INSTANCE.toBytes("D"), true)
+ // Note: The optimal scan boundary for the above query is ['CCC' -
*), however, I don't see an easy way to fix this currently so prioritizing.
Opened JIRA PHOENIX-5885
+ assertArrayEquals(ByteUtil.concat(PChar.INSTANCE.toBytes("C"),
PChar.INSTANCE.toBytes("B"), PChar.INSTANCE.toBytes("C")), scan.getStartRow());
+ assertArrayEquals(ByteUtil.concat(PChar.INSTANCE.toBytes("C"),
PChar.INSTANCE.toBytes("B"), PChar.INSTANCE.toBytes("C")), scan.getStartRow());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ViewUtilIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PhoenixRuntimeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexWithTableSchemaChangeIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexCoprocIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexBuildTimestampIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.ConcurrentMutationsExtendedIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.ChildViewsUseParentViewIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexVerificationResultRepositoryIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalImmutableNonTxIndexIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.IndexVerificationOutputRepositoryIT
Test results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/91//testReport/
Code Coverage results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/91//artifact/phoenix-core/target/site/jacoco/index.html
Console output:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/91//console
This message is automatically generated.
> Incorrect results with RVCs and AND operator
> --------------------------------------------
>
> Key: PHOENIX-5833
> URL: https://issues.apache.org/jira/browse/PHOENIX-5833
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 4.15.0
> Reporter: Bharath Vissapragada
> Assignee: Daniel Wong
> Priority: Critical
> Attachments: PHOENIX-5833.4.x.patch
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Phoenix version: 4.15-HBase-1.5
> -- Create a test table and populate a couple of rows.
> {noformat}
> create table repro_bug(a varchar(10) not null, b varchar(10) not null, c
> varchar(10) not null constraint pk primary key(a, b, c));
> upsert into repro_bug values('abc', 'def', 'RRSQ_IMKKL');
> upsert into repro_bug values('abc', 'def', 'RRS_ZYTDT');
> select * from repro_bug;
> +------+------+-------------+
> | A | B | C |
> +------+------+-------------+
> | abc | def | RRSQ_IMKKL |
> | abc | def | RRS_ZYTDT |
> +------+------+-------------+
> {noformat}
> -- Query 1 - Look for rows where C has a certain prefix - Returns correct
> result
> {noformat}
> select A, B, C from REPRO_BUG where C like 'RRS\\_%';
> +------+------+------------+
> | A | B | C |
> +------+------+------------+
> | abc | def | RRS_ZYTDT |
> +------+------+------------+
> {noformat}
> -- Query 2 - Look for rows where (a, b, c) > first row - Returns correct
> result
> {noformat}
> select A, B, C from REPRO_BUG where (A, B, C) > ('abc', 'def', 'RRSQ_IMKKL')
> +------+------+------------+
> | A | B | C |
> +------+------+------------+
> | abc | def | RRS_ZYTDT |
> +------+------+------------+
> {noformat}
> -- Query 3 - Combine the filters from Query 1 and Query2 - Returns incorrect
> result.. Ideally it should return the same row as above.
> {noformat}
> select A, B, C from REPRO_BUG where (A, B, C) > ('abc', 'def', 'RRSQ_IMKKL')
> AND C like 'RRS\\_%';
> +----+----+----+
> | A | B | C |
> +----+----+----+
> +----+----+----+
> {noformat}
> -- Explain for the above incase someone is interested.
> {noformat}
> explain select A, B, C from REPRO_BUG where (A, B, C) > ('abc', 'def',
> 'RRSQ_IMKKL') AND C like 'RRS\\_%';
> +----------------------------------------------------------------------------------------+-----------------+----------------+--------------+
> | PLAN
> | EST_BYTES_READ | EST_ROWS_READ | EST_INFO_TS |
> +----------------------------------------------------------------------------------------+-----------------+----------------+--------------+
> | CLIENT 1-CHUNK PARALLEL 1-WAY ROUND ROBIN RANGE SCAN OVER REPRO_BUG
> ['abcdef'] - [*] | null | null | null |
> | SERVER FILTER BY FIRST KEY ONLY AND C LIKE 'RRS\_%'
> | null | null | null |
> +----------------------------------------------------------------------------------------+-----------------+----------------+--------------+
> 2 rows selected (0.003 seconds)
> {noformat}
> I'm trying to poke around in the code to figure out the issue but my
> understanding of Phoenix is limited at this point. So creating a bug report
> incase someone can figure this out quickly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
