jpisaac commented on pull request #878: URL: https://github.com/apache/phoenix/pull/878#issuecomment-694380032
> Had a quick glance and looks good overall. Is it helpful to add interfaces for some of the `configuration` classes instead of directly adding solid implementations? @ChinmaySKulkarni All configuration classes are mapped to XML files (configs/definitions) so making them interfaces may not help and not add much value. Since they typically will have only getters and setters and there will be only one concrete implementation which matches the underlying XML structure. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
