[
https://issues.apache.org/jira/browse/PHOENIX-6058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17198887#comment-17198887
]
Hadoop QA commented on PHOENIX-6058:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/13011789/PHOENIX-6058.4.x.002.patch
against 4.x branch at commit .
ATTACHMENT ID: 13011789
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 0 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 release audit{color}. The applied patch generated 1 release
audit warnings (more than the master's current 0 warnings).
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ serverProps.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Integer.toString(60*60)); // An hour
+ serverProps.put(ScanInfoUtil.PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY,
Integer.toString(60*60)); // An hour
+ // By definition, if the max lookback feature is not enabled, then
delete markers and rows
+ // version can be removed by compaction any time, and thus there
is no window in which these mutations are
+ // preserved, i.e., the max lookback window size is zero. This
means all the mutations are effectively
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.OrphanViewToolIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.GlobalMutableNonTxIndexWithLazyPostBatchWriteIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.QueryLoggerIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.PointInTimeQueryIT
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.phoenix.end2end.StoreNullsIT.testQueryingHistory(StoreNullsIT.java:191)
at
org.apache.phoenix.end2end.AggregateIT.testAvgGroupByOrderPreservingWithStats(AggregateIT.java:182)
Test results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/107//testReport/
Code Coverage results:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/107//artifact/phoenix-core/target/site/jacoco/index.html
Release audit warnings:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/107//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/107//console
This message is automatically generated.
> When maxLookback is not enabled, IndexTool should not do deep verification
> --------------------------------------------------------------------------
>
> Key: PHOENIX-6058
> URL: https://issues.apache.org/jira/browse/PHOENIX-6058
> Project: Phoenix
> Issue Type: Bug
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Blocker
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6058.4.x.001.patch, PHOENIX-6058.4.x.002.patch
>
>
> IndexTool does two types of verification, verifying the latest row versions,
> and verifying all row versions within the maxLookback windows. Verifying just
> the latest version can be called shallow verification whereas verifying all
> versions can be called deep verification. The maxLookback feature preserves
> all row versions including delete markers within the maxLookback window. This
> allows IndexTool to compare all versions of data rows with all versions of
> the index rows within the window. However, due to a bug, when the maxLookback
> feature is not enabled, i.e., the maxLookback window is set to zero,
> IndexTool assumes the window size is infinite and thus does deep
> verification. Since some versions of the index rows can be removed by
> compaction independently if the maxLookback feature is not enabled, IndexTool
> may report missing or invalid index rows by doing deep verification.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
