priyankporwal commented on a change in pull request #889:
URL: https://github.com/apache/phoenix/pull/889#discussion_r493014166
##########
File path:
phoenix-tools/src/main/java/org/apache/phoenix/schema/SchemaExtractionProcessor.java
##########
@@ -326,8 +334,13 @@ private String convertPropertiesToString() {
if (optionBuilder.length() != 0) {
optionBuilder.append(", ");
}
- key =
columnFamilyName.equals(QueryConstants.DEFAULT_COLUMN_FAMILY)? key :
String.format("\"%s\".%s", columnFamilyName, key);
- optionBuilder.append(key+"="+value);
+ key =
columnFamilyName.equals(QueryConstants.DEFAULT_COLUMN_FAMILY)?
+ key : String.format("\"%s\".%s", columnFamilyName,
key);
+ if(!Character.isDigit(value.charAt(0)) &&
Review comment:
what does digit in the first position signify? Perhaps add a comment as
well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
