kadirozde commented on a change in pull request #891:
URL: https://github.com/apache/phoenix/pull/891#discussion_r493216064



##########
File path: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java
##########
@@ -768,7 +768,8 @@ public boolean verifySingleIndexRow(Result indexRow, 
IndexToolVerificationResult
                 }
             } else {
                 byte[] dataKey = indexMaintainer.buildDataRowKey(new 
ImmutableBytesWritable(indexRow.getRow()), viewConstants);
-                String errorMsg = "Not matching index row";
+                String errorMsg = String.format("Not matching index row. 
matchingCount=0. expectedIndex=%d. expectedMutationSize=%d. actualIndex=%d. 
actualMutationSize=%d. expectedTs=%d. actualTs=%d",

Review comment:
       The version of this file is not the most recent as I noticed that it 
does not have the MaxLookBack changes. The patch with the latest version should 
be different, I think. Also, there is no need to include expected and actual 
timestamps in the error message since they are reported as separate columns in 
the output table. We should fix those reported values instead. Please use the 
most recent version of IndexRebuildRegionScanner.java and resubmit your patch.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to