[ 
https://issues.apache.org/jira/browse/PHOENIX-6152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17200635#comment-17200635
 ] 

Istvan Toth commented on PHOENIX-6152:
--------------------------------------

[~RichardAntal] Our CI setup is not smart enough to figure out that this patch 
is for phoenix-thirdparty (and not for the phoenix repo).

Please link a PR instead, for easier review.

The process that you use for shading Protobuf is unnecessarily complex. You 
could use the guava POM as a template, since - unlike HBase - we don't need to 
do anything to Protobuf apart from shading it. 

> Add phoenix-shaded-protobuf to phoenix-thirdparty.
> --------------------------------------------------
>
>                 Key: PHOENIX-6152
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6152
>             Project: Phoenix
>          Issue Type: Task
>            Reporter: Richard Antal
>            Assignee: Richard Antal
>            Priority: Major
>         Attachments: PHOENIX-6152.master.v1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to