[
https://issues.apache.org/jira/browse/PHOENIX-6160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202989#comment-17202989
]
Hadoop QA commented on PHOENIX-6160:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 6m
9s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
0s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} 4.x Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
59s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
58s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m
40s{color} | {color:green} 4.x passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
48s{color} | {color:green} 4.x passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 3m
14s{color} | {color:blue} phoenix-core in 4.x has 957 extant spotbugs warnings.
{color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
3s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
57s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m
42s{color} | {color:red} phoenix-core: The patch generated 53 new + 379
unchanged - 40 fixed = 432 total (was 419) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
44s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} spotbugs {color} | {color:red} 3m
29s{color} | {color:red} phoenix-core generated 1 new + 956 unchanged - 1 fixed
= 957 total (was 957) {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red}130m 6s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
38s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}163m 6s{color} |
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:phoenix-core |
| | Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit)
ignored in
org.apache.phoenix.hbase.index.IndexRegionObserver.waitForPreviousConcurrentBatch(TableName,
IndexRegionObserver$BatchMutateContext) At IndexRegionObserver.java:ignored
in
org.apache.phoenix.hbase.index.IndexRegionObserver.waitForPreviousConcurrentBatch(TableName,
IndexRegionObserver$BatchMutateContext) At IndexRegionObserver.java:[line
878] |
| Failed junit tests | TEST-[RangeScanIT_0] |
| | phoenix.end2end.OrphanViewToolIT |
| | phoenix.end2end.index.GlobalMutableTxIndexIT |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6160 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13012206/PHOENIX-6160.4.x.001.patch
|
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux bd4a918f6a61 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 54ba102 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/artifact/patchprocess/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/artifact/patchprocess/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/testReport/ |
| Max. process+thread count | 3772 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/47/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.2 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Simplifying concurrent mutation handling for global Indexes
> -----------------------------------------------------------
>
> Key: PHOENIX-6160
> URL: https://issues.apache.org/jira/browse/PHOENIX-6160
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Kadir OZDEMIR
> Assignee: Kadir OZDEMIR
> Priority: Major
> Attachments: PHOENIX-6160.4.x.001.patch
>
>
> Please see the attached design document for the proposed simplification. The
> proposed design is simpler to understand and does not require a special
> handling of partial concurrent updates without indexed columns.
> One of the desired features for global indexes is to support atomic
> operations (ON_DUPLICATE_KEY statements). We have found that it is quite
> difficult to build such a feature on the current design as we need to add
> more case handling to the current design to handle data table update ordering
> issues. The proposed design does not require us to do changes on concurrent
> mutation handling for such features.
> The proposed design almost eliminates unverified index rows due to concurrent
> mutations. The index rows are left unverified only when batches fail to
> complete the data table updates. This leads to read performance improvement
> as repairing unverified rows is costly and each row repair adds several tens
> of milliseconds to the overall scan latency.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
