[
https://issues.apache.org/jira/browse/PHOENIX-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213019#comment-17213019
]
ASF GitHub Bot commented on PHOENIX-6164:
-----------------------------------------
stoty commented on pull request #37:
URL: https://github.com/apache/phoenix-connectors/pull/37#issuecomment-707636329
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 54s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +0 :ok: | mvndep | 8m 43s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 7m 13s | master passed |
| +1 :green_heart: | compile | 2m 22s | master passed |
| +1 :green_heart: | checkstyle | 0m 20s | master passed |
| +1 :green_heart: | javadoc | 2m 45s | master passed |
| +0 :ok: | spotbugs | 4m 23s | root in master has 111 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 0m 51s | phoenix-hive-base/phoenix4-hive in
master has 47 extant spotbugs warnings. |
| +0 :ok: | spotbugs | 0m 56s | phoenix-hive-base/phoenix5-hive in
master has 46 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| -1 :x: | mvninstall | 0m 6s | root in master failed. |
| +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch |
| -1 :x: | mvninstall | 0m 6s | root in the patch failed. |
| -1 :x: | compile | 0m 6s | root in the patch failed. |
| -1 :x: | javac | 0m 6s | root in the patch failed. |
| -1 :x: | checkstyle | 0m 4s | The patch fails to run checkstyle in
root |
| -1 :x: | whitespace | 0m 0s | The patch has 1 line(s) that end in
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 :green_heart: | xml | 0m 12s | The patch has no ill-formed XML
file. |
| -1 :x: | javadoc | 0m 6s | root in the patch failed. |
| -1 :x: | javadoc | 0m 10s | phoenix4-flume in the patch failed. |
| -1 :x: | javadoc | 0m 12s | phoenix5-flume in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix4-hive in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-hive in the patch failed. |
| -1 :x: | javadoc | 0m 8s | phoenix4-spark in the patch failed. |
| -1 :x: | javadoc | 0m 9s | phoenix5-spark in the patch failed. |
| -1 :x: | spotbugs | 0m 6s | root in the patch failed. |
| -1 :x: | spotbugs | 0m 8s | phoenix4-hive in the patch failed. |
| -1 :x: | spotbugs | 0m 9s | phoenix5-hive in the patch failed. |
||| _ Other Tests _ |
| -1 :x: | unit | 0m 6s | root in the patch failed. |
| +1 :green_heart: | asflicense | 1m 2s | The patch does not generate
ASF License warnings. |
| | | 39m 53s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix-connectors/pull/37 |
| Optional Tests | dupname asflicense javac javadoc unit xml compile
spotbugs hbaseanti checkstyle |
| uname | Linux f3f78b4ad34a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-connectors-personality.sh |
| git revision | master / 8c02df3 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt
|
| mvninstall |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt
|
| compile |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-compile-root.txt
|
| javac |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-compile-root.txt
|
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/buildtool-patch-checkstyle-root.txt
|
| whitespace |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/whitespace-eol.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-root.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-flume-base_phoenix4-flume.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-flume-base_phoenix5-flume.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-hive-base_phoenix4-hive.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-hive-base_phoenix5-hive.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-spark-base_phoenix4-spark.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-spark-base_phoenix5-spark.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-spotbugs-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-hive-base_phoenix4-hive.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-hive-base_phoenix5-hive.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/testReport/
|
| Max. process+thread count | 94 (vs. ulimit of 30000) |
| modules | C: . phoenix-connectors-phoenix4-compat
phoenix-connectors-phoenix5-compat phoenix-flume-base/phoenix4-flume
phoenix-flume-base/phoenix5-flume phoenix-hive-base/phoenix4-hive
phoenix-hive-base/phoenix5-hive phoenix-spark-base/phoenix4-spark
phoenix-spark-base/phoenix5-spark U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-Connectors-PreCommit-GitHub-PR/job/PR-37/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Rename phoenix4-compat and phoenix5-compat maven artifacts
> ----------------------------------------------------------
>
> Key: PHOENIX-6164
> URL: https://issues.apache.org/jira/browse/PHOENIX-6164
> Project: Phoenix
> Issue Type: Improvement
> Components: connectors
> Affects Versions: connectors-6.0.0
> Reporter: Istvan Toth
> Assignee: Richard Antal
> Priority: Minor
>
> The new connectors build uses compatibility modules.
> These have the coordinates org.apache.phoenix:phoenix4-compat andÂ
> org.apache.phoenix:phoenix5-compat
> These artifacts are connectors-specific, yet this is not apparent from their
> names.
> Rename them so that the relation is immediately apparent, to something like
> phoenix-connectors-phoenix4-compat .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
