[ 
https://issues.apache.org/jira/browse/PHOENIX-6178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213101#comment-17213101
 ] 

ASF GitHub Bot commented on PHOENIX-6178:
-----------------------------------------

stoty commented on pull request #918:
URL: https://github.com/apache/phoenix/pull/918#issuecomment-707722140


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |  36m  9s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   3m 19s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |  39m 52s |  master passed  |
   | +1 :green_heart: |  compile  |   1m 45s |  master passed  |
   | +1 :green_heart: |  javadoc  |   1m 30s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |  46m 34s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 36s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 36s |  the patch passed  |
   | +1 :green_heart: |  hadolint  |   0m  2s |  There were no new hadolint 
issues.  |
   | -1 :x: |  shellcheck  |   0m 10s |  The patch generated 7 new + 0 
unchanged - 0 fixed = 7 total (was 0)  |
   | -1 :x: |  shelldocs  |   0m  2s |  The patch generated 76 new + 0 
unchanged - 0 fixed = 76 total (was 0)  |
   | -1 :x: |  whitespace  |   0m  1s |  The patch has 1 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  5s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  javadoc  |   1m 31s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 109m 31s |  root in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 50s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 245m 46s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | phoenix.end2end.OrphanViewToolIT |
   |   | phoenix.end2end.UpsertSelectIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/918 |
   | Optional Tests | dupname asflicense shellcheck shelldocs hadolint javac 
javadoc unit xml compile |
   | uname | Linux 9d4846a0e3d3 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | master / 4b2ff49 |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | shellcheck | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/diff-patch-shellcheck.txt
 |
   | shelldocs | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/diff-patch-shelldocs.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/artifact/yetus-general-check/output/patch-unit-root.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/testReport/
 |
   | Max. process+thread count | 6704 (vs. ulimit of 30000) |
   | modules | C: phoenix-assembly . U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-918/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 shellcheck=0.7.0 
hadolint=1.17.5-0-g443423c |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Consider adopting the create-release scripts and process from HBase
> -------------------------------------------------------------------
>
>                 Key: PHOENIX-6178
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6178
>             Project: Phoenix
>          Issue Type: Wish
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>
> HBase has moved on to a new release script, which seems easier to use and has 
> docker support.
> Consider adopting it to Phoenix.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to