gokceni commented on a change in pull request #915:
URL: https://github.com/apache/phoenix/pull/915#discussion_r504315024
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java
##########
@@ -1103,13 +1104,21 @@ private RegionScanner rebuildIndices(final
RegionScanner innerScanner, final Reg
if (oldCoproc) {
return new IndexerRegionScanner(scanner, region, scan, env,
this);
} else {
- return new IndexRebuildRegionScanner(scanner, region, scan,
env, this);
+ if
(region.getTableDesc().hasCoprocessor(IndexRegionObserver.class.getCanonicalName()))
{
Review comment:
Is this an optimization for checking if this table is Index table
@kadirozde rather than querying the PTable and looking at its type?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
