[
https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213940#comment-17213940
]
Viraj Jasani edited comment on PHOENIX-6085 at 10/14/20, 2:07 PM:
------------------------------------------------------------------
[~RichardAntal], sorry to bother, but does this cover for this Jira
[https://github.com/apache/phoenix/pull/920] ?
I didn't know that this was a separate Jira. Apologies for the misunderstanding.
Thanks
was (Author: vjasani):
[~RichardAntal], sorry to bother, but does this cover for this Jira
[https://github.com/apache/phoenix/pull/920] ?
I didn't know that this was a separate Jira.
Thanks
> Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the
> upgrade path
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-6085
> URL: https://issues.apache.org/jira/browse/PHOENIX-6085
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Richard Antal
> Priority: Minor
> Labels: phoenix-hardening, quality-improvement
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6085.4.x.v1.patch, PHOENIX-6085.master.v1.patch
>
>
> We already make this call inside
> [CQSI.acquireUpgradeMutex()|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4220]
> and then call writeMutexCell() which calls this again
> [here|https://github.com/apache/phoenix/blob/1922895dfe5960dc025709b04acfaf974d3959dc/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L4244].
>
> We should move this to inside writeMutexCell() itself and throw
> UpgradeInProgressException if required there to avoid unnecessary expensive
> HBase admin API calls.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
