ChinmaySKulkarni commented on a change in pull request #923:
URL: https://github.com/apache/phoenix/pull/923#discussion_r505885857
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1451,7 +1454,35 @@ private TableDescriptor ensureTableCreated(byte[]
physicalTableName, PTableType
}
return null; // will never make it here
}
-
+
+ private boolean isSplitPolicyUpdatedForTaskTable(
+ final TableDescriptorBuilder tdBuilder) {
+ boolean isTaskTable = false;
+ String taskTable = PhoenixDatabaseMetaData.SYSTEM_TASK_NAME;
+ if (tdBuilder.build().getTableName().getNameAsString()
+ .equals(taskTable)) {
+ isTaskTable = true;
+ } else {
Review comment:
Can't we use the actual namespace mapping property to get the exact
expected name i.e. SYSTEM.TASK vs SYSTEM:TASK instead of trying both variations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
