[
https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17215030#comment-17215030
]
ASF GitHub Bot commented on PHOENIX-6125:
-----------------------------------------
ChinmaySKulkarni commented on a change in pull request #923:
URL: https://github.com/apache/phoenix/pull/923#discussion_r505885857
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1451,7 +1454,35 @@ private TableDescriptor ensureTableCreated(byte[]
physicalTableName, PTableType
}
return null; // will never make it here
}
-
+
+ private boolean isSplitPolicyUpdatedForTaskTable(
+ final TableDescriptorBuilder tdBuilder) {
+ boolean isTaskTable = false;
+ String taskTable = PhoenixDatabaseMetaData.SYSTEM_TASK_NAME;
+ if (tdBuilder.build().getTableName().getNameAsString()
+ .equals(taskTable)) {
+ isTaskTable = true;
+ } else {
Review comment:
Can't we use the actual namespace mapping property to get the exact
expected name i.e. SYSTEM.TASK vs SYSTEM:TASK instead of trying both variations?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make sure SYSTEM.TASK does not split
> ------------------------------------
>
> Key: PHOENIX-6125
> URL: https://issues.apache.org/jira/browse/PHOENIX-6125
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> To avoid problems such as
> [PHOENIX-5945|https://issues.apache.org/jira/browse/PHOENIX-5945] we can just
> prevent SYSTEM.TASK from splitting.
> Currently we only store relatively rare tasks inside SYSTEM.TASK and so we
> should probably be safe to assume that it only spans a single region. Note
> that we will also have to handle changing the split policy during the upgrade
> path for 4.15 operators.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
