[
https://issues.apache.org/jira/browse/PHOENIX-6125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216806#comment-17216806
]
ASF GitHub Bot commented on PHOENIX-6125:
-----------------------------------------
virajjasani commented on a change in pull request #923:
URL: https://github.com/apache/phoenix/pull/923#discussion_r507833595
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesUpgradeIT.java
##########
@@ -25,61 +25,68 @@
import java.util.Map;
import java.util.Properties;
+import org.apache.hadoop.hbase.TableName;
+import org.apache.hadoop.hbase.client.Admin;
import org.apache.phoenix.coprocessor.MetaDataProtocol;
import org.apache.phoenix.jdbc.PhoenixConnection;
+import org.apache.phoenix.jdbc.PhoenixDatabaseMetaData;
import org.apache.phoenix.jdbc.PhoenixEmbeddedDriver.ConnectionInfo;
import org.apache.phoenix.jdbc.PhoenixTestDriver;
import org.apache.phoenix.query.BaseTest;
import org.apache.phoenix.query.ConnectionQueryServices;
import org.apache.phoenix.query.ConnectionQueryServicesImpl;
import org.apache.phoenix.query.QueryServices;
import org.apache.phoenix.query.QueryServicesTestImpl;
+import org.apache.phoenix.schema.SystemTaskSplitPolicy;
import org.apache.phoenix.util.ReadOnlyProps;
import org.junit.BeforeClass;
import org.junit.Test;
import org.apache.phoenix.thirdparty.com.google.common.collect.Maps;
-public class SystemCatalogUpgradeIT extends BaseTest {
+/**
+ * Tests for upgrades of System tables.
+ */
+public class SystemTablesUpgradeIT extends BaseTest {
private static boolean reinitialize;
private static int countUpgradeAttempts;
private static long systemTableVersion =
MetaDataProtocol.getPriorVersion();
-
+
private static class PhoenixUpgradeCountingServices extends
ConnectionQueryServicesImpl {
public PhoenixUpgradeCountingServices(QueryServices services,
ConnectionInfo connectionInfo, Properties info) {
super(services, connectionInfo, info);
}
-
+
@Override
protected void setUpgradeRequired() {
super.setUpgradeRequired();
countUpgradeAttempts++;
}
-
+
Review comment:
These changes are specific only to whitespace issues that precommit
build reported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make sure SYSTEM.TASK does not split
> ------------------------------------
>
> Key: PHOENIX-6125
> URL: https://issues.apache.org/jira/browse/PHOENIX-6125
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> To avoid problems such as
> [PHOENIX-5945|https://issues.apache.org/jira/browse/PHOENIX-5945] we can just
> prevent SYSTEM.TASK from splitting.
> Currently we only store relatively rare tasks inside SYSTEM.TASK and so we
> should probably be safe to assume that it only spans a single region. Note
> that we will also have to handle changing the split policy during the upgrade
> path for 4.15 operators.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
