[
https://issues.apache.org/jira/browse/PHOENIX-6189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216900#comment-17216900
]
ASF GitHub Bot commented on PHOENIX-6189:
-----------------------------------------
ntshmah commented on a change in pull request #924:
URL: https://github.com/apache/phoenix/pull/924#discussion_r507907536
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java
##########
@@ -1677,6 +1677,8 @@ private void testUpsertSelectWithMultiByteChars(boolean
autoCommit) throws Excep
fail();
} catch (SQLException e) {
assertEquals(SQLExceptionCode.DATA_EXCEEDS_MAX_CAPACITY.getErrorCode(),
e.getErrorCode());
+ assertFalse(e.getMessage().contains("澴粖蟤य褻酃岤豦팑薰鄩脼ժ끦碉碉碉碉碉碉碉"));
+ assertTrue(e.getMessage().contains(String.valueOf(20)));
Review comment:
nit: You could check for `VARCHAR(20)` instead of just `20`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> DATA_EXCEEDS_MAX_CAPACITY exception error string should contain column name
> instead of actual value
> ----------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6189
> URL: https://issues.apache.org/jira/browse/PHOENIX-6189
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.14.3
> Reporter: Xinyi Yan
> Assignee: Xinyi Yan
> Priority: Trivial
>
> UpsertCompiler raised DATA_EXCEEDS_MAX_CAPACITY exception that contains
> column value instead of the column name.
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java#L1263
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
