[
https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218739#comment-17218739
]
ASF GitHub Bot commented on PHOENIX-6197:
-----------------------------------------
stoty commented on a change in pull request #933:
URL: https://github.com/apache/phoenix/pull/933#discussion_r509877509
##########
File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java
##########
@@ -840,10 +840,16 @@ public static void doMajorCompaction(Connection conn,
String tableName) throws E
byte[] markerRowKey = Bytes.toBytes("TO_DELETE");
Put put = new Put(markerRowKey);
- put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
+ long timestamp = 0;
+ // We do not want to wait an hour because of
PHOENIX_MAX_LOOKBACK_AGE_CONF_KEY
+ // So set the timestamp of the put and delete as early as possible
+ put.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
+ QueryConstants.EMPTY_COLUMN_VALUE_BYTES, timestamp,
+ QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
htable.put(put);
Delete delete = new Delete(markerRowKey);
- delete.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
QueryConstants.EMPTY_COLUMN_VALUE_BYTES);
+ delete.addColumn(QueryConstants.DEFAULT_COLUMN_FAMILY_BYTES,
Review comment:
Not needed, identical timestamp will be deleted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> AggregateIT and StoreNullsIT hangs
> ----------------------------------
>
> Key: PHOENIX-6197
> URL: https://issues.apache.org/jira/browse/PHOENIX-6197
> Project: Phoenix
> Issue Type: Bug
> Components: core
> Affects Versions: 5.1.0, 4.16.0
> Reporter: Istvan Toth
> Priority: Blocker
>
> Recent 4.x builds don't finish.
> The maven output shows that AggregateIT and StoreNullsIT are started, but
> never complete.
> All 4.x CI builds seem to be affected.
> I can see the same hang on some master builds (on HBase 2.3, though that may
> be a coincidence)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
