[
https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219839#comment-17219839
]
ASF GitHub Bot commented on PHOENIX-6198:
-----------------------------------------
gokceni commented on a change in pull request #937:
URL: https://github.com/apache/phoenix/pull/937#discussion_r511031557
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -192,6 +191,14 @@ public static IndexDisableLoggingType fromValue(byte[]
value) {
}
}
+ /**
+ * Which table to use as the source table
+ */
+ public enum SourceTable {
Review comment:
nit: We have a similar enum in the IndexScrutinyTool. Can we re use it?
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java
##########
@@ -285,6 +293,11 @@ public static IndexDisableLoggingType fromValue(byte[]
value) {
, "Disable logging of failed verification rows for BEFORE, " +
"AFTER, or BOTH verify jobs");
+ private static final Option USE_INDEX_TABLE_AS_SOURCE_OPTION =
+ new Option("fi", "from-index", false,
+ "To verify every row in the index table has a corresponding row in
the data table. " +
+ "Only supported for global indexes. This option is applicable
to BEFORE and ONLY type verification jobs");
Review comment:
I think stating this is clearer: This option is applicable only when -v
ONLY or -v BEFORE is provided.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add option to IndexTool to specify the source table for scan
> ------------------------------------------------------------
>
> Key: PHOENIX-6198
> URL: https://issues.apache.org/jira/browse/PHOENIX-6198
> Project: Phoenix
> Issue Type: Sub-task
> Reporter: Tanuj Khurana
> Assignee: Tanuj Khurana
> Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
