[
https://issues.apache.org/jira/browse/PHOENIX-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219961#comment-17219961
]
Hadoop QA commented on PHOENIX-6202:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
34s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} dupname {color} | {color:green} 0m
1s{color} | {color:green} No case conflicting files found. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s{color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m
0s{color} | {color:red} The patch doesn't appear to include any new or modified
tests. Please justify why no new tests are needed for this patch. Also please
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 8m
12s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
55s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
40s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
41s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} spotbugs {color} | {color:blue} 2m
50s{color} | {color:blue} phoenix-core in master has 970 extant spotbugs
warnings. {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m
24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m
51s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 1m
43s{color} | {color:red} phoenix-core: The patch generated 3 new + 2813
unchanged - 1 fixed = 2816 total (was 2814) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} spotbugs {color} | {color:green} 3m
4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 93m 59s{color}
| {color:red} phoenix-core in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
27s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}123m 38s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/97/artifact/patchprocess/Dockerfile
|
| JIRA Issue | PHOENIX-6202 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13014046/PHOENIX-6202.patch |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux ed94d948da36 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / 3d5cb8d |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/97/artifact/patchprocess/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/97/artifact/patchprocess/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/97/testReport/ |
| Max. process+thread count | 6752 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/97/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> New column in index gets added as PK with CASCADE INDEX
> -------------------------------------------------------
>
> Key: PHOENIX-6202
> URL: https://issues.apache.org/jira/browse/PHOENIX-6202
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Swaroopa Kadam
> Assignee: Swaroopa Kadam
> Priority: Major
> Attachments: PHOENIX-6202-4.x-v1.patch, PHOENIX-6202.4.x.v2.patch,
> PHOENIX-6202.patch
>
>
>
> {code:java}
> @Test
> public void testGlobalAddColumns() throws Exception {
> Properties props = PropertiesUtil.deepCopy(TEST_PROPERTIES);
> try (Connection conn = DriverManager.getConnection(getUrl(), props))
> {
> conn.setAutoCommit(true); String tableName = "TBL_" + generateUniqueName();
> String idxName = "IND_" + generateUniqueName(); String baseTableDDL = "CREATE
> TABLE " + tableName + " (PK1 VARCHAR NOT NULL, V1 VARCHAR, V2 CHAR(15)
> CONSTRAINT NAME_PK PRIMARY KEY(PK1)) ";
> conn.createStatement().execute(baseTableDDL);
> String indexDDL = "CREATE INDEX " + idxName + " ON " + tableName + " (PK1)
> include (V1, V2) ";
> conn.createStatement().execute(indexDDL);
> String upsert = "UPSERT INTO " + tableName + " (PK1, V1, V2) VALUES ('PK1',
> 'V1', 'V2')"; conn.createStatement().executeUpdate(upsert);
> dumpTable(idxName); String alterTable = "ALTER TABLE " + tableName + " ADD
> V3 VARCHAR CASCADE INDEX ALL";
> conn.createStatement().execute(alterTable); String upsert2 = "UPSERT INTO " +
> tableName + " (PK1, V1, V2,V3) VALUES ('PK2', 'V1', 'V2', 'V3')";
> conn.createStatement().executeUpdate(upsert2);
> dumpTable(idxName);
> String selectFromIndex = "SELECT PK1, V3, V1, V2 FROM " + tableName + " where
> V1='V1' AND V2='V2'";
> ResultSet rs = conn.createStatement().executeQuery("EXPLAIN " +
> selectFromIndex);
> }
> }
> public static void dumpTable(Table hTable) {
> try {
> Scan scan = new Scan();
> scan.setRaw(true);
> scan.setMaxVersions();
> System.out.println("Table Name : " + hTable.getName().getNameAsString());
> ResultScanner scanner = hTable.getScanner(scan);
> for (Result result = scanner.next(); result != null; result =
> scanner.next()) {
> for (Cell cell : result.rawCells())
> { String cellString = cell.toString(); System.out.println(cellString + "
> value : " + Bytes.toStringBinary(CellUtil.cloneValue(cell))); }
> }
> } catch (Exception e) {
> //ignore
> }
> }
> {code}
>
>
> output:
>
> PK1/0:\x00\x00\x00\x00/1603217119002/Put/vlen=1/seqid=0 ****** value : \x01
> PK1/0:\x80\x0B/1603217119002/Put/vlen=2/seqid=0 ****** value : V1
> PK1/0:\x80\x0C/1603217119002/Put/vlen=15/seqid=0 ****** value : V2
> PK2\x00V3/0:\x00\x00\x00\x00/1603217125595/Put/vlen=1/seqid=0 ****** value :
> \x01
> PK2\x00V3/0:\x80\x0B/1603217125595/Put/vlen=2/seqid=0 ****** value : V1
> PK2\x00V3/0:\x80\x0C/1603217125595/Put/vlen=15/seqid=0 ****** value : V2
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
