[ 
https://issues.apache.org/jira/browse/PHOENIX-6208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17221197#comment-17221197
 ] 

ASF GitHub Bot commented on PHOENIX-6208:
-----------------------------------------

stoty commented on pull request #941:
URL: https://github.com/apache/phoenix/pull/941#issuecomment-717034429


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m  5s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  10m 43s |  4.x passed  |
   | -1 :x: |  compile  |   0m 11s |  phoenix-assembly in 4.x failed.  |
   | -1 :x: |  javadoc  |   0m  9s |  phoenix-assembly in 4.x failed.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   5m 17s |  the patch passed  |
   | -1 :x: |  compile  |   0m  8s |  phoenix-assembly in the patch failed.  |
   | -1 :x: |  javac  |   0m  8s |  phoenix-assembly in the patch failed.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  xml  |   0m  3s |  The patch has no ill-formed XML 
file.  |
   | -1 :x: |  javadoc  |   0m  8s |  phoenix-assembly in the patch failed.  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  8s |  phoenix-assembly in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m  9s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  18m 40s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/941 |
   | Optional Tests | dupname asflicense javac javadoc unit xml compile |
   | uname | Linux e79abcb9eb6a 4.15.0-65-generic #74-Ubuntu SMP Tue Sep 17 
17:06:04 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / ac0538b |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/branch-compile-phoenix-assembly.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/branch-javadoc-phoenix-assembly.txt
 |
   | compile | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/patch-compile-phoenix-assembly.txt
 |
   | javac | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/patch-compile-phoenix-assembly.txt
 |
   | javadoc | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/patch-javadoc-phoenix-assembly.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/artifact/yetus-general-check/output/patch-unit-phoenix-assembly.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/testReport/
 |
   | Max. process+thread count | 76 (vs. ulimit of 30000) |
   | modules | C: phoenix-assembly U: phoenix-assembly |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-941/1/console
 |
   | versions | git=2.7.4 maven=3.3.9 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Backport the assembly changes in PHOENIX-6178 to 4.x
> ----------------------------------------------------
>
>                 Key: PHOENIX-6208
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6208
>             Project: Phoenix
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 4.16.0
>            Reporter: Istvan Toth
>            Assignee: Istvan Toth
>            Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to