stoty commented on pull request #935: URL: https://github.com/apache/phoenix/pull/935#issuecomment-717647493
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 5m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ 4.x Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 10m 44s | 4.x passed | | +1 :green_heart: | compile | 1m 22s | 4.x passed | | +1 :green_heart: | checkstyle | 10m 10s | 4.x passed | | +1 :green_heart: | javadoc | 1m 50s | 4.x passed | | +0 :ok: | spotbugs | 3m 59s | root in 4.x has 1007 extant spotbugs warnings. | | +0 :ok: | spotbugs | 2m 41s | phoenix-core in 4.x has 953 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 5m 24s | the patch passed | | +1 :green_heart: | compile | 1m 22s | the patch passed | | +1 :green_heart: | cc | 1m 22s | the patch passed | | +1 :green_heart: | javac | 1m 22s | the patch passed | | -1 :x: | checkstyle | 10m 20s | root: The patch generated 242 new + 22485 unchanged - 111 fixed = 22727 total (was 22596) | | +1 :green_heart: | prototool | 0m 1s | There were no new prototool issues. | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. | | -1 :x: | javadoc | 0m 43s | phoenix-core generated 3 new + 97 unchanged - 3 fixed = 100 total (was 100) | | -1 :x: | javadoc | 1m 2s | root generated 3 new + 129 unchanged - 3 fixed = 132 total (was 132) | | -1 :x: | spotbugs | 3m 7s | phoenix-core generated 2 new + 952 unchanged - 1 fixed = 954 total (was 953) | | -1 :x: | spotbugs | 4m 5s | root generated 2 new + 1006 unchanged - 1 fixed = 1008 total (was 1007) | ||| _ Other Tests _ | | -1 :x: | unit | 122m 19s | root in the patch failed. | | +1 :green_heart: | asflicense | 1m 3s | The patch does not generate ASF License warnings. | | | | 189m 46s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Found reliance on default encoding in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean):in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean): new String(byte[]) At AddColumnMutator.java:[line 341] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331] | | FindBugs | module:root | | | Found reliance on default encoding in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean):in org.apache.phoenix.coprocessor.AddColumnMutator.validateAndAddMetadata(PTable, byte[][], List, Region, List, List, long, long, boolean): new String(byte[]) At AddColumnMutator.java:[line 341] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line 331] | | Failed junit tests | phoenix.end2end.index.LocalMutableTxIndexIT | | | phoenix.end2end.OrphanViewToolIT | | | phoenix.end2end.UpsertSelectIT | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/935 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile cc prototool xml | | uname | Linux 5c9c5c9e0156 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | 4.x / ac0538b | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-checkstyle-root.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt | | javadoc | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/new-spotbugs-root.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/artifact/yetus-general-check/output/patch-unit-root.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/testReport/ | | Max. process+thread count | 7059 (vs. ulimit of 30000) | | modules | C: phoenix-core . U: . | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/4/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
