tkhurana commented on a change in pull request #937:
URL: https://github.com/apache/phoenix/pull/937#discussion_r514599687
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
##########
@@ -660,6 +663,19 @@ public static String
getIndexToolIndexTableName(Configuration configuration) {
return configuration.get(INDEX_TOOL_INDEX_TABLE_NAME);
}
+ public static void setIndexToolSourceTable(Configuration configuration,
+ IndexScrutinyTool.SourceTable sourceTable) {
+ Preconditions.checkNotNull(configuration);
+ Preconditions.checkNotNull(sourceTable);
+ configuration.set(INDEX_TOOL_SOURCE_TABLE, sourceTable.name());
+ }
+
+ public static IndexScrutinyTool.SourceTable
getIndexToolSourceTable(Configuration configuration) {
+ Preconditions.checkNotNull(configuration);
+ return
IndexScrutinyTool.SourceTable.valueOf(configuration.get(INDEX_TOOL_SOURCE_TABLE,
+ IndexScrutinyTool.SourceTable.DATA_TABLE_SOURCE.name()));
Review comment:
By default, we are going to use the data table as the source which is
what the current behavior is. We have to return a string from which the
appropriate enum is constructed. I am not sure what is the question here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
