[
https://issues.apache.org/jira/browse/PHOENIX-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223252#comment-17223252
]
ASF GitHub Bot commented on PHOENIX-6126:
-----------------------------------------
stoty commented on pull request #948:
URL: https://github.com/apache/phoenix/pull/948#issuecomment-719059910
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 5m 21s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 26s | master passed |
| +1 :green_heart: | compile | 0m 58s | master passed |
| +1 :green_heart: | checkstyle | 1m 40s | master passed |
| +1 :green_heart: | javadoc | 0m 44s | master passed |
| +0 :ok: | spotbugs | 2m 53s | phoenix-core in master has 969 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 33s | the patch passed |
| +1 :green_heart: | compile | 0m 54s | the patch passed |
| +1 :green_heart: | javac | 0m 54s | the patch passed |
| -1 :x: | checkstyle | 1m 42s | phoenix-core: The patch generated 9
new + 2897 unchanged - 13 fixed = 2906 total (was 2910) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 43s | the patch passed |
| -1 :x: | spotbugs | 3m 9s | phoenix-core generated 2 new + 967
unchanged - 2 fixed = 969 total (was 969) |
||| _ Other Tests _ |
| -1 :x: | unit | 171m 55s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 27s | The patch does not generate
ASF License warnings. |
| | | 214m 5s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may
fail to clean up java.sql.Statement Obligation to clean up resource created at
ConnectionQueryServicesImpl.java:up java.sql.Statement Obligation to clean up
resource created at ConnectionQueryServicesImpl.java:[line 3205] is not
discharged |
| | org.apache.phoenix.query.ConnectionQueryServicesImpl$12.call() may
fail to close Statement At ConnectionQueryServicesImpl.java:Statement At
ConnectionQueryServicesImpl.java:[line 3205] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/948 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 4f9b12eb25e1 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | master / ff46e35 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/testReport/
|
| Max. process+thread count | 6456 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-948/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> All createViewAddChildLink requests will go to the same region of
> SYSTEM.CHILD_LINK
> -----------------------------------------------------------------------------------
>
> Key: PHOENIX-6126
> URL: https://issues.apache.org/jira/browse/PHOENIX-6126
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Minor
> Fix For: 5.1.0, 4.16.0
>
>
> Currently, since there is no split policy defined for SYSTEM.CHILD_LINK, it
> can split by default.
> If SYSTEM.CHILD_LINK does split, then when the client invokes
> ConnectionQueryServices.childLinkMetaDataCoprocessorExec(), we always invoke
> the endpoint on the first region that contains linking rows for that parent
> (see
> [this|https://github.com/apache/phoenix/blob/e3c7b4bdce2524eb4fd1e7eb0ccd3454fcca81ce/phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java#L1629]).
>
> Thus, no matter which region would actually contain the parent→child link,
> the first region is the one that has to always service the request and its RS
> finally issues the mutation to the correct region. Note that the
> mutateRowsWithLocks() call inside
> [ChildLinkMetaDataEndpoint.createViewAddChildLink()|https://github.com/apache/phoenix/blob/e3c7b4bdce2524eb4fd1e7eb0ccd3454fcca81ce/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/ChildLinkMetaDataEndpoint.java#L105]
> doesn’t fail even if the region doesn’t contain that row since we pass in an
> empty list for rowsToLock.
> During view creation, this request will lead to a Put of just 1 row and we
> have all the information to be able to pass in the exact row key instead of
> just the prefix (parent tenantId, parent schema, parent name). This should
> distribute load to all regions of SYSTEM.CHILD_LINK.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
