[
https://issues.apache.org/jira/browse/PHOENIX-4910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224987#comment-17224987
]
Hadoop QA commented on PHOENIX-4910:
------------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m
0s{color} | {color:blue} Docker mode activated. {color} |
| {color:red}-1{color} | {color:red} patch {color} | {color:red} 0m 11s{color}
| {color:red} PHOENIX-4910 does not apply to master. Rebase required? Wrong
Branch? See
https://yetus.apache.org/documentation/in-progress/precommit-patchnames for
help. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | PHOENIX-4910 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12941125/PHOENIX-4910.002.patch
|
| Console output |
https://ci-hadoop.apache.org/job/PreCommit-PHOENIX-Build/151/console |
| versions | git=2.17.1 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
> Improvements to spooled MappedByteBufferQueue files
> ---------------------------------------------------
>
> Key: PHOENIX-4910
> URL: https://issues.apache.org/jira/browse/PHOENIX-4910
> Project: Phoenix
> Issue Type: Bug
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Fix For: 5.1.1, 4.16.1
>
> Attachments: PHOENIX-4910.001.patch, PHOENIX-4910.002.patch
>
>
> A user ran into a JVM bug which appears to have caused a RegionServer to
> crash while running a topN aggregate query. This left a large number of files
> in {{/tmp}} after the RS had gone away (due to a JVM SIGBUS crash).
> MappedByteBufferQueue will buffer results in memory up to 20MB by default
> (controlled by {{phoenix.query.spoolThresholdBytes}}) and then start
> appending them to a file. I'm seeing two things which could be improved:
> * If the RS exits abnormally, there is no process to clean up files - would
> be nice to register the {{deleteOnExit()}} hook to try to clean these up.
> * There is no ability to control where MappedByteBufferQueue writes its
> spool file - would be nice to use something other than /tmp (I think we have
> a property to control this already in our config..)
> FYI [[email protected]]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
