richardantal commented on a change in pull request #929:
URL: https://github.com/apache/phoenix/pull/929#discussion_r516815108
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ViewIndexIT.java
##########
@@ -280,6 +282,64 @@ public void testCoprocsOnGlobalNonMTImmutableViewIndex()
throws Exception {
testCoprocsOnGlobalViewIndexHelper(false, false);
}
+ @Test
+ public void testDroppingColumnWhileCreatingIndex() throws Exception {
+ String schemaName = "S1";
+ String tableName = generateUniqueName();
+ String viewSchemaName = "S1";
+ String fullTableName = SchemaUtil.getTableName(schemaName, tableName);
+ String indexName = "IND_" + generateUniqueName();
+ String viewName = "VIEW_" + generateUniqueName();
+ String fullViewName = SchemaUtil.getTableName(viewSchemaName,
viewName);
+
+ createBaseTable(schemaName, tableName, false, null, null, true);
+ try (Connection conn = getConnection()) {
+ conn.setAutoCommit(true);
+ conn.createStatement().execute("CREATE VIEW " + fullViewName + "
AS SELECT * FROM " + fullTableName);
+ conn.commit();
+
+ final int[] exceptionCode = new int[1];
Review comment:
`exceptionCode` is accessed from an inner class so has to be final, in
order to be able to change its value from the other thread it has to be an
array.
We can use AtomicInteger array but I am not sure if it adds any value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
