ChinmaySKulkarni commented on a change in pull request #936:
URL: https://github.com/apache/phoenix/pull/936#discussion_r520833354
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
##########
@@ -134,6 +137,7 @@ public TableResultIterator(MutationState mutationState,
Scan scan, ScanMetricsHo
this.retry=plan.getContext().getConnection().getQueryServices().getProps()
.getInt(QueryConstants.HASH_JOIN_CACHE_RETRIES,
QueryConstants.DEFAULT_HASH_JOIN_CACHE_RETRIES);
IndexUtil.setScanAttributesForIndexReadRepair(scan, table,
plan.getContext().getConnection());
+ scan.setAttribute(BaseScannerRegionObserver.SERVER_PAGING, TRUE_BYTES);
Review comment:
Makes sense. For old clients this attribute won't be set so it will be
like current behavior. For new clients we can set page size to Long.MAX_VALUE
to disable it. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
