[
https://issues.apache.org/jira/browse/PHOENIX-6212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229755#comment-17229755
]
ASF GitHub Bot commented on PHOENIX-6212:
-----------------------------------------
stoty commented on pull request #962:
URL: https://github.com/apache/phoenix/pull/962#issuecomment-725215453
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 55s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 13m 2s | 4.x passed |
| +1 :green_heart: | compile | 1m 17s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 36s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 50s | 4.x passed |
| +0 :ok: | spotbugs | 3m 50s | phoenix-core in 4.x has 946 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 7m 19s | the patch passed |
| +1 :green_heart: | compile | 1m 12s | the patch passed |
| +1 :green_heart: | javac | 1m 12s | the patch passed |
| +1 :green_heart: | checkstyle | 0m 35s | the patch passed |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 55s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 58s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 190m 39s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 30s | The patch does not generate
ASF License warnings. |
| | | 229m 9s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.AlterTableIT |
| | phoenix.end2end.index.MutableIndexReplicationIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/962 |
| JIRA Issue | PHOENIX-6212 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 4dac62f879c9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 21e729f |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/testReport/
|
| Max. process+thread count | 6088 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-962/1/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve SystemCatalogIT.testSystemTableSplit() to ensure no splitting occurs
> when splitting is disabled
> -------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6212
> URL: https://issues.apache.org/jira/browse/PHOENIX-6212
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
>
> We should fix
> [SystemCatalogIT.testSystemTableSplit()|https://github.com/apache/phoenix/blob/8aa243d1e35a2a9ac85c6c30f1e958289973c214/phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogIT.java#L65]
> so that it ensures that splitting SYSTEM.CATALOG fails if either
> phoenix.allow.system.catalog.rollback=true and/or
> phoenix.system.catalog.splittable=false
> Currently this test is not really ensuring that a split fails (see [this
> comment|https://github.com/apache/phoenix/pull/949#discussion_r516276781] for
> more details)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
