[ 
https://issues.apache.org/jira/browse/PHOENIX-6218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230460#comment-17230460
 ] 

ASF GitHub Bot commented on PHOENIX-6218:
-----------------------------------------

stoty commented on pull request #961:
URL: https://github.com/apache/phoenix/pull/961#issuecomment-725944480


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 44s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | -1 :x: |  test4tests  |   0m  0s |  The patch doesn't appear to include 
any new or modified tests. Please justify why no new tests are needed for this 
patch. Also please list what manual steps were performed to verify this patch.  
|
   ||| _ 4.x Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |  12m 27s |  4.x passed  |
   | +1 :green_heart: |  compile  |   1m 16s |  4.x passed  |
   | +1 :green_heart: |  checkstyle  |   0m 44s |  4.x passed  |
   | +1 :green_heart: |  javadoc  |   0m 56s |  4.x passed  |
   | +0 :ok: |  spotbugs  |   4m 12s |  phoenix-core in 4.x has 946 extant 
spotbugs warnings.  |
   ||| _ Patch Compile Tests _ |
   | +1 :green_heart: |  mvninstall  |   8m  2s |  the patch passed  |
   | +1 :green_heart: |  compile  |   1m 12s |  the patch passed  |
   | +1 :green_heart: |  javac  |   1m 12s |  the patch passed  |
   | -1 :x: |  checkstyle  |   0m 43s |  phoenix-core: The patch generated 11 
new + 355 unchanged - 13 fixed = 366 total (was 368)  |
   | +1 :green_heart: |  whitespace  |   0m  1s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  javadoc  |   1m  0s |  the patch passed  |
   | +1 :green_heart: |  spotbugs  |   4m 17s |  the patch passed  |
   ||| _ Other Tests _ |
   | -1 :x: |  unit  | 203m 14s |  phoenix-core in the patch failed.  |
   | +1 :green_heart: |  asflicense  |   0m 32s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 243m 14s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | Failed junit tests | phoenix.end2end.index.PartialIndexRebuilderIT |
   |   | phoenix.end2end.index.GlobalIndexOptimizationIT |
   |   | phoenix.schema.stats.NoOpStatsCollectorIT |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.40 ServerAPI=1.40 base: 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/phoenix/pull/961 |
   | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti 
checkstyle compile |
   | uname | Linux 83fd0bb0a25d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev/phoenix-personality.sh |
   | git revision | 4.x / 565b0ea |
   | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
 |
   | unit | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
 |
   |  Test Results | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/testReport/
 |
   | Max. process+thread count | 5987 (vs. ulimit of 30000) |
   | modules | C: phoenix-core U: phoenix-core |
   | Console output | 
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-961/3/console
 |
   | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Rows deleted count for client side deletes is incorrect for immutable tables 
> with indexes
> -----------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-6218
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6218
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Tanuj Khurana
>            Assignee: Tanuj Khurana
>            Priority: Major
>
> For immutable tables if the best query plan for delete uses the data table 
> and it has an index, the rows deleted count reported is  #(rows 
> updated)/#(tables updated)  where # of rows updated only includes data table 
> rows but the number of tables includes data + index. This reduces the row 
> count than the actual rows deleted count.
> The same problem can also happen if the best query plan uses the index table 
> and there are more than one index present on the data table. In this case the 
> rows updated will include both data table and the index table (one used by 
> the query plan) but because there are other indexes also present the #(tables 
> updated) will be more and we will get an inaccurate result.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to