[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231036#comment-17231036
]
ASF GitHub Bot commented on PHOENIX-6186:
-----------------------------------------
stoty commented on pull request #935:
URL: https://github.com/apache/phoenix/pull/935#issuecomment-726405428
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include
1 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 10m 32s | 4.x passed |
| +1 :green_heart: | compile | 1m 27s | 4.x passed |
| +1 :green_heart: | checkstyle | 11m 22s | 4.x passed |
| +1 :green_heart: | javadoc | 1m 51s | 4.x passed |
| +0 :ok: | spotbugs | 4m 1s | root in 4.x has 1000 extant spotbugs
warnings. |
| +0 :ok: | spotbugs | 2m 42s | phoenix-core in 4.x has 946 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 21s | the patch passed |
| +1 :green_heart: | compile | 1m 22s | the patch passed |
| +1 :green_heart: | cc | 1m 22s | the patch passed |
| +1 :green_heart: | javac | 1m 22s | the patch passed |
| -1 :x: | checkstyle | 11m 29s | root: The patch generated 401 new +
25081 unchanged - 238 fixed = 25482 total (was 25319) |
| +1 :green_heart: | prototool | 0m 2s | There were no new prototool
issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | xml | 0m 1s | The patch has no ill-formed XML
file. |
| -1 :x: | javadoc | 0m 43s | phoenix-core generated 3 new + 97
unchanged - 3 fixed = 100 total (was 100) |
| -1 :x: | javadoc | 1m 4s | root generated 3 new + 129 unchanged - 3
fixed = 132 total (was 132) |
| -1 :x: | spotbugs | 3m 5s | phoenix-core generated 3 new + 945
unchanged - 1 fixed = 948 total (was 946) |
| -1 :x: | spotbugs | 4m 5s | root generated 3 new + 999 unchanged - 1
fixed = 1002 total (was 1000) |
||| _ Other Tests _ |
| -1 :x: | unit | 1m 22s | root in the patch failed. |
| +1 :green_heart: | asflicense | 0m 21s | The patch does not generate
ASF License warnings. |
| | | 64m 13s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a
mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line
330] |
| |
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may
fail to clean up java.sql.Statement Obligation to clean up resource created at
UpgradeUtil.java:up java.sql.Statement Obligation to clean up resource created
at UpgradeUtil.java:[line 2604] is not discharged |
| |
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)
passes a nonconstant String to an execute or addBatch method on an SQL
statement At UpgradeUtil.java:to an execute or addBatch method on an SQL
statement At UpgradeUtil.java:[line 2604] |
| FindBugs | module:root |
| |
org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.LAST_DDL_TIMESTAMP_BYTES is a
mutable array At MetaDataEndpointImpl.java: At MetaDataEndpointImpl.java:[line
330] |
| |
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection) may
fail to clean up java.sql.Statement Obligation to clean up resource created at
UpgradeUtil.java:up java.sql.Statement Obligation to clean up resource created
at UpgradeUtil.java:[line 2604] is not discharged |
| |
org.apache.phoenix.util.UpgradeUtil.bootstrapLastDDLTimestamp(Connection)
passes a nonconstant String to an execute or addBatch method on an SQL
statement At UpgradeUtil.java:to an execute or addBatch method on an SQL
statement At UpgradeUtil.java:[line 2604] |
| Failed junit tests | phoenix.util.PhoenixRuntimeTest |
| | phoenix.compile.WhereCompilerTest |
| | phoenix.compile.TenantSpecificViewIndexCompileTest |
| | phoenix.compile.WhereOptimizerTest |
| | phoenix.mapreduce.util.PhoenixConfigurationUtilTest |
| | phoenix.compile.ViewCompilerTest |
| | phoenix.compile.QueryCompilerTest |
| | phoenix.compile.QueryOptimizerTest |
| | phoenix.query.QueryPlanTest |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/935 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile cc prototool xml |
| uname | Linux e994088abb66 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 565b0ea |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-checkstyle-root.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-javadoc-javadoc-phoenix-core.txt
|
| javadoc |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/diff-javadoc-javadoc-root.txt
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html
|
| spotbugs |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/new-spotbugs-root.html
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/artifact/yetus-general-check/output/patch-unit-root.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/testReport/
|
| Max. process+thread count | 486 (vs. ulimit of 30000) |
| modules | C: phoenix-core . U: . |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-935/9/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.4 prototool=1.10.0-dev |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Store table metadata last modified timestamp in PTable / System.Catalog
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6186
> URL: https://issues.apache.org/jira/browse/PHOENIX-6186
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6186-4.x.patch
>
>
> There are many reasons why it's useful to know when a particular table's
> metadata was last modified. It's helpful when solving cache coherency
> problems, and also in order to interact with external schema registries which
> may have multiple versions of a particular schema and require a timestamp to
> resolve ambiguities.
> This JIRA will add a last modified timestamp field to System.Catalog, to be
> updated both when creating a table/view and also when adding or removing a
> column. Changing purely internal Phoenix properties will not update the
> timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
