stoty commented on a change in pull request #959:
URL: https://github.com/apache/phoenix/pull/959#discussion_r522813831



##########
File path: dev/create-release/phoenix-rm/Dockerfile
##########
@@ -52,6 +52,11 @@ RUN wget -qO- 
"https://www.apache.org/dyn/mirrors/mirrors.cgi?action=download&fi
         tar xvz -C /opt
 ENV YETUS_HOME /opt/apache-yetus-${YETUS_VERSION}
 
+# Install protobuf-2.5 protoc binary from maven central, as that seems to be 
the only binary available
+RUN mkdir /opt/protobuf-2.5.0

Review comment:
       It doesn't make the HBase protobuf version mess any worse than it 
already is :)
   We use unshaded 2.5 for the coprocessor api, just as in Phoenix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to