[
https://issues.apache.org/jira/browse/PHOENIX-6191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232396#comment-17232396
]
ASF GitHub Bot commented on PHOENIX-6191:
-----------------------------------------
stoty commented on pull request #966:
URL: https://github.com/apache/phoenix/pull/966#issuecomment-727635323
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 23s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files
found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any
anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any
@author tags. |
| -1 :x: | test4tests | 0m 0s | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 11m 12s | 4.x passed |
| +1 :green_heart: | compile | 0m 53s | 4.x passed |
| +1 :green_heart: | checkstyle | 1m 40s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 43s | 4.x passed |
| +0 :ok: | spotbugs | 2m 52s | phoenix-core in 4.x has 946 extant
spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 14s | the patch passed |
| +1 :green_heart: | compile | 0m 55s | the patch passed |
| +1 :green_heart: | javac | 0m 55s | the patch passed |
| -1 :x: | checkstyle | 1m 42s | phoenix-core: The patch generated 1
new + 2824 unchanged - 4 fixed = 2825 total (was 2828) |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace
issues. |
| +1 :green_heart: | javadoc | 0m 41s | the patch passed |
| +1 :green_heart: | spotbugs | 3m 3s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 185m 49s | phoenix-core in the patch failed. |
| +1 :green_heart: | asflicense | 0m 37s | The patch does not generate
ASF License warnings. |
| | | 219m 30s | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | phoenix.end2end.DeleteIT |
| | phoenix.end2end.index.GlobalImmutableTxIndexIT |
| | phoenix.end2end.DropIndexedColsIT |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.40 ServerAPI=1.40 base:
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-966/3/artifact/yetus-general-check/output/Dockerfile
|
| GITHUB PR | https://github.com/apache/phoenix/pull/966 |
| JIRA Issue | PHOENIX-6191 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti
checkstyle compile |
| uname | Linux 93a77fb01df6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9
23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / 110f5b7 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-966/3/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt
|
| unit |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-966/3/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt
|
| Test Results |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-966/3/testReport/
|
| Max. process+thread count | 6269 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output |
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-966/3/console
|
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Creating a view which has its own new columns should also do checkAndPut
> checks on SYSTEM.MUTEX
> -----------------------------------------------------------------------------------------------
>
> Key: PHOENIX-6191
> URL: https://issues.apache.org/jira/browse/PHOENIX-6191
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Chinmay Kulkarni
> Priority: Critical
> Fix For: 5.1.0, 4.16.0
>
>
> Currently, when creating a view we do conditional writes with a checkAndPut
> to SYSTEM.MUTEX for the keys:
> (<physical parent's schema name>, <physical parent's table name>, <column
> name>)
> for each column in the view WHERE clause. Similarly, when issuing an ALTER
> TABLE/VIEW, we do a conditional write with a checkAndPut to SYSTEM.MUTEX for
> the key:
> (<physical parent's schema name>, <physical parent's table name>, <name of
> the column to add/drop>)
> to prevent conflicting modifications between a base table/view and its child
> views. However, if we create a view with its own new columns, for ex:
> {code:sql}
> CREATE VIEW V1 (NEW_COL1 INTEGER, NEW_COL2 INTEGER) AS SELECT * FROM T1 WHERE
> B = 10;
> {code}
> we will not do a checkAndPut with the new columns being added to the view
> (NEW_COL1 and NEW_COL2) thus conflicting concurrent mutations may occur to a
> parent in this case, for ex: a simultaneous ALTER TABLE/VIEW of the parent
> which adds NEW_COL1 as a VARCHAR. This will lead to data being unable to be
> read properly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
