[
https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17232946#comment-17232946
]
ASF GitHub Bot commented on PHOENIX-6186:
-----------------------------------------
gjacoby126 commented on pull request #935:
URL: https://github.com/apache/phoenix/pull/935#issuecomment-728212707
@shahrs87 - Of the three findbugs errors, the first is unclear to me, the
second is complaining about a potential resource leak in the boostrap code
(valid complaint) and the third is complaining about a potential SQL injection
vulnerability (incorrect, but understandable). I've changed it to use a
PreparedStatement in a try-with-resources executing a constant string.
Went through the checkstyle findings. The line lengths checks looks
misconfigured (it's 80 but should be 100, and we routinely let things a little
longer than 100 slide). I did go through and fix a bunch of whitespace
complaints around if and for blocks, plus marking some params final, to clear
out some of the noise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Store table metadata last modified timestamp in PTable / System.Catalog
> -----------------------------------------------------------------------
>
> Key: PHOENIX-6186
> URL: https://issues.apache.org/jira/browse/PHOENIX-6186
> Project: Phoenix
> Issue Type: New Feature
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Priority: Major
> Fix For: 4.16.0
>
> Attachments: PHOENIX-6186-4.x.patch
>
>
> There are many reasons why it's useful to know when a particular table's
> metadata was last modified. It's helpful when solving cache coherency
> problems, and also in order to interact with external schema registries which
> may have multiple versions of a particular schema and require a timestamp to
> resolve ambiguities.
> This JIRA will add a last modified timestamp field to System.Catalog, to be
> updated both when creating a table/view and also when adding or removing a
> column. Changing purely internal Phoenix properties will not update the
> timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
