yanxinyi commented on a change in pull request #955:
URL: https://github.com/apache/phoenix/pull/955#discussion_r524741262
##########
File path:
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -1107,6 +1108,16 @@ private void addCoprocessors(byte[] tableName,
HTableDescriptor descriptor,
}
}
}
+
+ // The priority for this co-processor should be set higher than
the GlobalIndexChecker so that the read repair scans
+ // are intercepted by the TTLAwareRegionObserver and only the rows
that are not ttl-expired are returned.
+ if (!SchemaUtil.isSystemTable(tableName)) {
+ if
(!descriptor.hasCoprocessor(PhoenixTTLRegionObserver.class.getName())) {
+ descriptor.addCoprocessor(
+ PhoenixTTLRegionObserver.class.getName(), null,
priority-2, null);
Review comment:
why priority - 2 here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]