stoty commented on a change in pull request #969:
URL: https://github.com/apache/phoenix/pull/969#discussion_r525038798
##########
File path: bin/phoenix_utils.py
##########
@@ -77,7 +77,7 @@ def findClasspath(command_name):
return tryDecode(subprocess.Popen(command, shell=True,
stdout=subprocess.PIPE).stdout.read())
def setPath():
- PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client.jar"
+ PHOENIX_CLIENT_JAR_PATTERN = "phoenix-client*[!s][!t].jar"
Review comment:
This will still match sources:
$ls -l phoenix-client*[!s][!t].jar
-rw-r--r-- 1 stoty staff 75651719 Nov 17 11:04
phoenix-client-5.1.0-SNAPSHOT-sources.jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04
phoenix-client-5.1.0-SNAPSHOT.jar
This would not:
$]ls -l phoenix-client*[!s].jar
-rw-r--r-- 1 stoty staff 144017266 Nov 17 11:04
phoenix-client-5.1.0-SNAPSHOT.jar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
