stoty commented on pull request #970: URL: https://github.com/apache/phoenix/pull/970#issuecomment-728903568
:broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | +0 :ok: | reexec | 1m 26s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 1 new or modified test files. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 14m 28s | master passed | | +1 :green_heart: | compile | 1m 2s | master passed | | +1 :green_heart: | checkstyle | 3m 15s | master passed | | +1 :green_heart: | javadoc | 0m 47s | master passed | | +0 :ok: | spotbugs | 3m 11s | phoenix-core in master has 962 extant spotbugs warnings. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 9m 12s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | -1 :x: | checkstyle | 3m 16s | phoenix-core: The patch generated 182 new + 10076 unchanged - 40 fixed = 10258 total (was 10116) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | javadoc | 0m 47s | the patch passed | | -1 :x: | spotbugs | 3m 21s | phoenix-core generated 8 new + 958 unchanged - 4 fixed = 966 total (was 962) | ||| _ Other Tests _ | | -1 :x: | unit | 163m 57s | phoenix-core in the patch failed. | | +1 :green_heart: | asflicense | 0m 30s | The patch does not generate ASF License warnings. | | | | 208m 47s | | | Reason | Tests | |-------:|:------| | FindBugs | module:phoenix-core | | | Initialization circularity between org.apache.phoenix.jdbc.PhoenixDatabaseMetaData and org.apache.phoenix.query.QueryConstants At PhoenixDatabaseMetaData.java:org.apache.phoenix.query.QueryConstants At PhoenixDatabaseMetaData.java:[lines 99-1871] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.OLD_SYSTEM_TASK_NAME_BYTES is a mutable array At PhoenixDatabaseMetaData.java: At PhoenixDatabaseMetaData.java:[line 394] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_TASK_HISTORY_NAME_BYTES is a mutable array At StatisticsUtil.java: At StatisticsUtil.java:[line 78] | | | org.apache.phoenix.jdbc.PhoenixDatabaseMetaData.SYSTEM_TASK_QUEUE_NAME_BYTES is a mutable array At StatisticsUtil.java: At StatisticsUtil.java:[line 77] | | | org.apache.phoenix.query.ConnectionQueryServicesImpl.createOtherSystemTables(PhoenixConnection) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:up java.sql.Statement Obligation to clean up resource created at ConnectionQueryServicesImpl.java:[line 3450] is not discharged | | | Exception is caught when Exception is not thrown in org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTask(PhoenixConnection, Map) At ConnectionQueryServicesImpl.java:is not thrown in org.apache.phoenix.query.ConnectionQueryServicesImpl.upgradeSystemTask(PhoenixConnection, Map) At ConnectionQueryServicesImpl.java:[line 4223] | | | org.apache.phoenix.query.ConnectionlessQueryServicesImpl.init(String, Properties) may fail to clean up java.sql.Statement Obligation to clean up resource created at ConnectionlessQueryServicesImpl.java:clean up java.sql.Statement Obligation to clean up resource created at ConnectionlessQueryServicesImpl.java:[line 382] is not discharged | | | org.apache.phoenix.schema.task.Task.deleteTask(PhoenixConnection, PTable$TaskType, Timestamp, String, String, String, boolean, String) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at Task.java:String, boolean, String) may fail to clean up java.sql.Statement on checked exception Obligation to clean up resource created at Task.java:[line 191] is not discharged | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/phoenix/pull/970 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile | | uname | Linux 7dc99e3fb6bf 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev/phoenix-personality.sh | | git revision | master / 243ac64 | | Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 | | checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt | | spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html | | unit | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt | | Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/testReport/ | | Max. process+thread count | 6245 (vs. ulimit of 30000) | | modules | C: phoenix-core U: phoenix-core | | Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-970/2/console | | versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
