[
https://issues.apache.org/jira/browse/PHOENIX-6155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234048#comment-17234048
]
ASF GitHub Bot commented on PHOENIX-6155:
-----------------------------------------
ChinmaySKulkarni commented on a change in pull request #960:
URL: https://github.com/apache/phoenix/pull/960#discussion_r525555394
##########
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java
##########
@@ -319,7 +323,26 @@ public void testUpdatedSplitPolicyForSysTask() throws
Exception {
+ compatibleClientVersion,
Review comment:
We should rename this test since we are no longer just checking that the
split policy is updated. Also, better if we can do something like the following:
1. Connect with an old client: If <4.15, SYS.TASK doesn't even exist, so
nothing to do. If 4.15, confirm that SYS.TASK **doesn't** have the coproc
loaded.
2. Then connect with a new client (4.16) which will trigger the metadata
upgrade and update the coproc. Now do your check for existence of the coproc.
Similarly can be done for the split policy too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Prevent doing direct upserts into SYSTEM.TASK from the client
> -------------------------------------------------------------
>
> Key: PHOENIX-6155
> URL: https://issues.apache.org/jira/browse/PHOENIX-6155
> Project: Phoenix
> Issue Type: Improvement
> Affects Versions: 5.0.0, 4.15.0
> Reporter: Chinmay Kulkarni
> Assignee: Viraj Jasani
> Priority: Major
> Fix For: 5.1.0, 4.16.0
>
> Attachments: PHOENIX-6155.4.x.000.patch, PHOENIX-6155.4.x.001.patch,
> PHOENIX-6155.4.x.002.patch, PHOENIX-6155.4.x.003.patch
>
>
> In environments with namespace-mapping enabled, we will have to grant write
> access to clients in order to make direct upserts into SYSTEM.TASK. Currently
> we add a task from the client-side
> [here|https://github.com/apache/phoenix/blob/4.x/phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java#L4654].
> In order to implement other Jiras like
> [PHOENIX-6154|https://issues.apache.org/jira/browse/PHOENIX-6154] we also may
> need to interact with the SYSTEM.TASK table from the client-side.
> Instead of doing direct upserts into this table, we should add an endpoint on
> SYSTEM.TASK and clients should interact with that.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
