ChinmaySKulkarni commented on a change in pull request #947:
URL: https://github.com/apache/phoenix/pull/947#discussion_r526542789
##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -957,4 +962,35 @@ public static int getClientVersion(Scan scan) {
public static void setClientVersion(Scan scan, int version) {
scan.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION,
Bytes.toBytes(version));
}
+
+ public static void getDummyResult(byte[] rowKey, List<Cell> result) {
+ result.clear();
Review comment:
I didn't understand this part. Shouldn't `result` always be empty when
it reaches this point? And if it isn't, aren't we overwriting the actually read
data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
