[ 
https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235124#comment-17235124
 ] 

ASF GitHub Bot commented on PHOENIX-6207:
-----------------------------------------

kadirozde commented on a change in pull request #947:
URL: https://github.com/apache/phoenix/pull/947#discussion_r526549458



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/util/ScanUtil.java
##########
@@ -957,4 +962,35 @@ public static int getClientVersion(Scan scan) {
     public static void setClientVersion(Scan scan, int version) {
         scan.setAttribute(BaseScannerRegionObserver.CLIENT_VERSION, 
Bytes.toBytes(version));
     }
+
+    public static void getDummyResult(byte[] rowKey, List<Cell> result) {
+        result.clear();
+        KeyValue keyValue =
+                KeyValueUtil.newKeyValue(rowKey, 0,
+                        rowKey.length, EMPTY_BYTE_ARRAY, EMPTY_BYTE_ARRAY,
+                        0, EMPTY_BYTE_ARRAY, 0, EMPTY_BYTE_ARRAY.length);
+        result.add(keyValue);

Review comment:
       Is it possible to have a column with a column family name and a column 
qualifier name such that the byte array representation of these names map to 
empty byte array? I assume it is not possible. How do you even express that 
within a SQL statement? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Paged server side grouped aggregate operations
> ----------------------------------------------
>
>                 Key: PHOENIX-6207
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-6207
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 5.0.0, 4.14.3
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.16.0
>
>         Attachments: PHOENIX-6207.4.x.001.patch, PHOENIX-6207.4.x.002.patch, 
> PHOENIX-6207.4.x.003.patch, PHOENIX-6207.4.x.004.patch, 
> PHOENIX-6207.4.x.005.patch, PHOENIX-6207.master.001.patch
>
>
> Phoenix provides the option of performing query operations on the client or 
> server side. This is decided by the Phoenix optimizer based on configuration 
> parameters. For the server side option, the table operation is parallelized 
> such that multiple table regions are scanned. However, currently there is no 
> paging capability and the server side operation can take long enough lead to 
> HBase client timeouts. Putting a limit on the processing time within a single 
> RPC call (i.e., the next operation time on the aggregate scanner) on the 
> server side using a Phoenix level paging is highly desirable. A similar 
> paging mechanism has been already implemented for index rebuild and 
> verification operations and proven to be effective to prevent timeouts. This 
> Jira is for implementing this paging for the server side grouped aggregate 
> operations. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to