richardantal commented on pull request #944: URL: https://github.com/apache/phoenix/pull/944#issuecomment-731246068
Thx @gjacoby126 for the review! You are right, the only difference between the 2 dropChildViews functions should be that one will try lazily. (The original function was edited simultaneously and I did not realise it, and failed to rebase well.) The original one was used after an HBase admin call but I get rid of it. I have added a small commentary to the functions and created a common part which should be the same in both functions. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
